generated from eclipse-score/module_template
-
Notifications
You must be signed in to change notification settings - Fork 2
[pipaudit] Add option to ignore vulnerabilities #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the pipaudit rule, adding an option to ignore vulnerabilities. Sometimes a vulnerability does not have a fix yet. In such a case, the user must be able to ignore those as there is no other option for third-party libraries.
The vulnerability `GHSA-4xh5-x5gv-qwph` is now affecting pip 25.2 as well but there is still no fix for it. Hence, it needs to be tolerated for now.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
lucasmuna
reviewed
Oct 30, 2025
third_party/pip/BUILD
Outdated
Comment on lines
56
to
58
| ignore_vulnerability = [ | ||
| "GHSA-4xh5-x5gv-qwph", # Added because there is no fix yet for pip 25.2. | ||
| ], |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not add it as a fix is already available with pip 25.3
e524551 to
1104004
Compare
1104004 to
bbeb777
Compare
antonkri
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the pipaudit rule, adding an option to ignore vulnerabilities.
Sometimes a vulnerability does not have a fix yet. In such a case, the user must be able to ignore those as there is no other option for third-party libraries.
One such case is the vulnerability
https://github.com/advisories/GHSA-4xh5-x5gv-qwph, which is now affecting pip 25.2 as well but there is still no fix for it. Hence, it needs to be tolerated.