Skip to content

Conversation

@jannowotsch
Copy link
Contributor

Align the rules_python python versions between workspace and bzlmod mode, in particular update the version for workspace mode to 1.4.1.

With the update a breaking change on how the python interpreter is referenced got introduced in rules_python and required changes.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 46099412-e36d-4119-ade7-ea009311dd51
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (62 packages loaded, 10 targets configured)

Analyzing: target //:license-check (70 packages loaded, 10 targets configured)

Analyzing: target //:license-check (114 packages loaded, 1519 targets configured)

Analyzing: target //:license-check (123 packages loaded, 2335 targets configured)

Analyzing: target //:license-check (128 packages loaded, 2370 targets configured)

Analyzing: target //:license-check (130 packages loaded, 4379 targets configured)

INFO: Analyzed target //:license-check (132 packages loaded, 4626 targets configured).
[8 / 13] checking cached actions
[8 / 13] [Prepa] JavaToolchainCompileClasses external/rules_java~/toolchains/platformclasspath_classes
[11 / 13] checking cached actions
[11 / 13] [Prepa] JavaToolchainCompileBootClasspath external/rules_java~/toolchains/platformclasspath.jar
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.622s, Critical Path: 0.20s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt -review -project automotive.score -repo https://github.com/eclipse-score/bazel-tools-python -token
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copy link
Contributor

@lucasmuna lucasmuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. They basically dropped the defs.bzl with rules_python >= 1.0.0.

load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")

_VERSION = "0.40.0" # Update `README.md` if you change this.
_VERSION = "1.4.1" # Update `README.md` if you change this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got that we are updating this to match the bzlmod version, but wouldn't it be better to already go for the latest one?

The main thing is to update it to >= 1.0.0, so no hard thoughts on my side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which version causes it, but updating to 1.7.0 contains more breaking changes, such as flags that have been removed. So I would stick with 1.4.1 for now to not make the PR bigger.

Align the rules_python python versions between workspace and bzlmod
mode, in particular update the version for workspace mode to 1.4.1.

With the update a breaking change on how the python interpreter is
referenced got introduced in rules_python and required changes.
@jannowotsch jannowotsch force-pushed the align-rules_python-versions branch from 5354665 to 6e0a04a Compare November 18, 2025 08:57
@antonkri antonkri self-requested a review November 18, 2025 12:26
@antonkri antonkri merged commit 4f79f23 into eclipse-score:main Nov 24, 2025
6 of 7 checks passed
@jannowotsch jannowotsch deleted the align-rules_python-versions branch December 18, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants