-
Notifications
You must be signed in to change notification settings - Fork 2
[bazel] Align rules_python versions #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bazel] Align rules_python versions #9
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
lucasmuna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. They basically dropped the defs.bzl with rules_python >= 1.0.0.
| load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe") | ||
|
|
||
| _VERSION = "0.40.0" # Update `README.md` if you change this. | ||
| _VERSION = "1.4.1" # Update `README.md` if you change this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got that we are updating this to match the bzlmod version, but wouldn't it be better to already go for the latest one?
The main thing is to update it to >= 1.0.0, so no hard thoughts on my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure which version causes it, but updating to 1.7.0 contains more breaking changes, such as flags that have been removed. So I would stick with 1.4.1 for now to not make the PR bigger.
Align the rules_python python versions between workspace and bzlmod mode, in particular update the version for workspace mode to 1.4.1. With the update a breaking change on how the python interpreter is referenced got introduced in rules_python and required changes.
5354665 to
6e0a04a
Compare
Align the rules_python python versions between workspace and bzlmod mode, in particular update the version for workspace mode to 1.4.1.
With the update a breaking change on how the python interpreter is referenced got introduced in rules_python and required changes.