-
Notifications
You must be signed in to change notification settings - Fork 6
Replace bind-mount with volume as Bazel Cache #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace bind-mount with volume as Bazel Cache #21
Conversation
Since bind-mounting the Bazel cache from the host causes various problems (problematic access rights; incompatibilities with CodeSpaces) without major benefits, we use now a regular named volume as persistent cache.
|
I cannot open a codespace on https://github.com/Elektrobit/eclipse-score_devcontainer/tree/use-docker-volume-as-bazel-cache: Correction: it seems to open regardless of that error. Nothing bazel or cache related in the log. |
|
Oh |
it can cause some weird issues with CodeSpaces, and we do not use it directly at the moment anyway
|
Well, and the fact that this repository does not use the DevContainer it creates (chicken-egg-problem ;-). It also does not use Bazel (no use for it, since the build must be done using devcontainer-cli anyway). Anyway, I tried to run a CodeSpace on it, and that just worked fine. Apparently the failure has something to do with access rights (you have no write access to this fork), some CodeSpaces magic that will do a fork on your behalf, and an implementation detail of this forking (it uses a Anyway, I disabled the auto-fetch of git lfs also here for now, since we do not use it directly at the moment. |
it is not required anymore, since now a volume mount is used instead of a bind mount
We could try building the container using bazel |
|
Are you now mounting the local eclipse-s-core-bazel-cache located in the respective repo? Or am I reading the mount incorrectly? |
It should be a Docker volume. Thus it is still somewhere on the host, but under full control of Docker. If it does not exist, Docker will take care to create it. Among the many repos / devcontainer instances it will still be shared. |
|
Ah I see. But it will not be shared with non-devcontainer bazel-cache. I guess that's fine. Until people run out of disk space 😆 |
Since bind-mounting the Bazel cache from the host causes various problems (problematic access rights; incompatibilities with CodeSpaces) without major benefits, we use now a regular named volume as persistent cache.
Closes #18 (now hopefully for real)