Add Rust feature to container #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This installs rustc, rustfmt and more Rust tools. Then the image should have all tools preinstalled to build and debug Rust code.
lurtz
commented
Sep 26, 2025
src/s-core-devcontainer/.devcontainer/s-core-local/tests/test_default.sh
Outdated
Show resolved
Hide resolved
opajonk
reviewed
Oct 2, 2025
Comment on lines
+35
to
+40
| "cargo", | ||
| "clippy", | ||
| // "miri", // only available at nightly | ||
| "rust-analyzer", | ||
| "rust-src", | ||
| "rustfmt" |
Contributor
There was a problem hiding this comment.
These tools you should check in src/s-core-devcontainer/test-project/test.sh
opajonk
approved these changes
Oct 10, 2025
Member
|
we should not have compilers in the container. But since this PR simply changes how it's installed, thats not the place to discuss it. |
AlexanderLanin
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs rustc, rustfmt and more Rust tools. Then the image should have all tools preinstalled to build and debug Rust code.
Closes #30