Fix bazel compile commands syntax, use correct platform name for ARM64 #35
Conversation
There, "bash" must be omitted from the call.
At least on MacOS, the current name does not work. platform/arm64 is correct.
There, "bash" must be omitted from the call. This also works for Bazel 8.x, so let's use that.
opajonk
changed the title
opajonk
changed the title
lurtz
left a comment
lurtz
left a comment
There was a problem hiding this comment.
With such a bugfix PR, which needs to fix what was just merged, I wonder if we should improve automated testing. E.g. when building devcontainers I used to be less concerned if the tool versions are what we expect, but more that these tools actually get the job done.
In this case toy projects with Bazel 7.5.0 an 8.3.0 might be good enough. Both could contain a small piece of Rust and C++ code which is compiled and we check that e.g. files for code completion exist.
| set -euxo pipefail | ||
|
|
||
| devcontainer build --platform linux/aarch64 --workspace-folder src/s-core-devcontainer --image-name ghcr.io/eclipse-score/devcontainer --cache-from ghcr.io/eclipse-score/devcontainer | ||
| devcontainer build --platform linux/arm64 --workspace-folder src/s-core-devcontainer --image-name ghcr.io/eclipse-score/devcontainer --cache-from ghcr.io/eclipse-score/devcontainer |
There was a problem hiding this comment.
can we make this one optional? Locally I already commented building for ARM, because I only need / use x86
There was a problem hiding this comment.
No the default is to build all. If you want to do something else locally - no problem ;-)
| # Pre-install a fixed Bazel version, setup the bash command completion | ||
| export USE_BAZEL_VERSION=${bazel_version} | ||
| bazel help completion bash > /tmp/bazel-complete.bash | ||
| bazel help completion > /tmp/bazel-complete.bash |
There was a problem hiding this comment.
I wonder why the shells set e did not cause a failure here
There was a problem hiding this comment.
It does not fail in this case, since there Bazel 8.4.x (as specified) is always used. I changed this line only to have it consistent with the other line that had to be changed.
There was no build failure. Only the platform name was wrong, but that I could not figure out before actually using a Mac and trying to pull the image. And actually, the Mac image works fine, but all Bazel builds fail. Obviously, no one ever checked/created Bazel toolchains for |
3 participants
There, "bash" must be omitted from the call. This also works for Bazel 8.x, so let's use that.
Also, the platform name must be
linux/arm64. At least for MacOS this seems to be the correct syntax.