-
Notifications
You must be signed in to change notification settings - Fork 19
tooling: Integrate CLI helper #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tooling: Integrate CLI helper #247
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: ✅ Passed Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| """ | ||
|
|
||
| data = data + ["@score_docs_as_code//src:docs_assets"] | ||
| call_path = native.package_name() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's now hardcoded to be in the root. But I guess it's not properly enforced anywhere.
Can we add something like:
if (call_path != "")
fail("docs must be included in the module root")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how that would play with dependencies from other repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is the way: fail("docs must be included in the module root") . i have tested in score and it triggers the error if I move the docs() call in docs/BUILD for example.
Defined common commands. bazel run //:help Signed-off-by: Nicolae Dicu <nicolae.dicu.ext@qorix.ai>
Signed-off-by: Nicolae Dicu <nicolae.dicu.ext@qorix.ai>
d6e97da to
8210030
Compare
Defined common commands. bazel run //:help
📌 Description
🚨 Impact Analysis
✅ Checklist
Related: #246