-
Notifications
You must be signed in to change notification settings - Fork 19
wip #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip #253
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
aa99a88 to
f366b7a
Compare
cfce698 to
4ad5c8f
Compare
4ad5c8f to
98a2d21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves error message formatting in metamodel validation by making warnings more human-readable and converting string-based need type references to actual ScoreNeedType objects for better type checking.
- Replaces cryptic regex pattern warnings with descriptive messages about required reference types
- Converts string-based need type references in YAML configuration to typed object references
- Adds postprocessing logic to resolve need type names to actual ScoreNeedType objects at runtime
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extensions/score_metamodel/yaml_parser.py | Updates function signature to use more specific type annotation |
| src/extensions/score_metamodel/tests/rst/options/test_options_options.rst | Updates expected test output format for new error messages |
| src/extensions/score_metamodel/metamodel_types.py | Adds union types to support both regex strings and ScoreNeedType lists for links |
| src/extensions/score_metamodel/metamodel.yaml | Converts string need type references to comma-separated type names |
| src/extensions/score_metamodel/checks/check_options.py | Implements new error logging with descriptive messages and type resolution |
| src/extensions/score_metamodel/init.py | Adds postprocessing to convert type name strings to ScoreNeedType objects |
Comments suppressed due to low confidence (1)
src/extensions/score_metamodel/checks/check_options.py:1
- This assertion suggests temporary code. Replace with proper type checking or error handling, especially since the type hints indicate this function should handle both strings and lists.
# *******************************************************************************
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Old:
New: