Skip to content

Conversation

@AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Sep 16, 2025

Old:

=========== 32 non-fatal warnings (will become fatal in the future) ============
requirements/requirements.rst:634: tool_req__docs_dd_link_source_code_link.satisfies (['PROCESS_gd_req__req_attr_impl', 'PROCESS_gd_req__impl_design_code_link', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:96: tool_req__docs_common_attr_title.satisfies (['PROCESS_gd_req__req_attr_title', 'PROCESS_gd_req__saf_attr_title', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:126: tool_req__docs_common_attr_desc_wording.satisfies (['PROCESS_gd_req__req_desc_weak', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:793: tool_req__docs_stdreq_types.satisfies (['tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:784: tool_req__docs_wf_types.satisfies (['tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:353: tool_req__docs_req_types.satisfies (['PROCESS_gd_req__req_structure', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:199: tool_req__docs_common_attr_status.satisfies (['PROCESS_gd_req__req_attr_status', 'PROCESS_gd_req__arch_attr_status', 'PROCESS_gd_req__saf_attr_status', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:434: tool_req__docs_req_link_satisfies_allowed.satisfies (['PROCESS_gd_req__req_linkage', 'PROCESS_gd_req__req_traceability', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:257: tool_req__docs_doc_types.satisfies (['PROCESS_gd_req__doc_types', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:270: tool_req__docs_doc_attr.satisfies (['PROCESS_gd_req__doc_author', 'PROCESS_gd_req__doc_approver', 'PROCESS_gd_req__doc_reviewer', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:765: tool_req__docs_tvr_status.satisfies (['PROCESS_gd_req__tool_attr_status', 'PROCESS_gd_req__tool_check_mandatory', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:738: tool_req__docs_tvr_safety.satisfies (['PROCESS_gd_req__tool_attr_safety_affected', 'PROCESS_gd_req__tool_check_mandatory', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:751: tool_req__docs_tvr_security.satisfies (['PROCESS_gd_req__tool_attr_security_affected', 'PROCESS_gd_req__tool_check_mandatory', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:382: tool_req__docs_req_attr_reqtype.satisfies (['PROCESS_gd_req__req_attr_type', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:173: tool_req__docs_common_attr_safety.satisfies (['PROCESS_gd_req__req_attr_safety', 'PROCESS_gd_req__arch_attr_safety', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:373: tool_req__docs_req_attr_rationale.satisfies (['PROCESS_gd_req__req_attr_rationale', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:148: tool_req__docs_common_attr_security.satisfies (['PROCESS_gd_req__req_attr_security', 'PROCESS_gd_req__arch_attr_security', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:397: tool_req__docs_req_attr_reqcov.satisfies (['PROCESS_gd_req__req_attr_req_cov', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:412: tool_req__docs_req_attr_testcov.satisfies (['PROCESS_gd_req__req_attr_test_covered', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:478: tool_req__docs_arch_types.satisfies (['PROCESS_gd_req__arch_hierarchical_structure', 'PROCESS_gd_req__arch_build_blocks', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:605: tool_req__docs_arch_views.satisfies (['PROCESS_gd_req__arch_viewpoints', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:807: tool_req__docs_saf_types.satisfies (['PROCESS_gd_req__saf_structure', 'PROCESS_gd_req__saf_attr_uid', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:920: tool_req__docs_saf_attr_dfa_failure_id.satisfies (['PROCESS_gd_req__saf_attr_failure_id', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:850: tool_req__docs_saf_attrs_sufficient.satisfies (['PROCESS_gd_req__saf_attr_sufficient', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:874: tool_req__docs_saf_attrs_content.satisfies (['PROCESS_gd_req__saf_argument', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:886: tool_req__docs_saf_attrs_violates.satisfies (['PROCESS_gd_req__saf_linkage_check', 'PROCESS_gd_req__saf_linkage', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:839: tool_req__docs_saf_attrs_mitigation_issue.satisfies (['PROCESS_gd_req__saf_attr_mitigation_issue', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:824: tool_req__docs_saf_attrs_mitigated_by.satisfies (['PROCESS_gd_req__saf_attr_mitigated_by', 'PROCESS_gd_req__saf_attr_requirements', 'PROCESS_gd_req__saf_attr_requirements_check', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:907: tool_req__docs_saf_attr_fmea_fault_id.satisfies (['PROCESS_gd_req__saf_attr_fault_id', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:462: tool_req__docs_common_attr_safety_link_check.satisfies (['PROCESS_gd_req__req_linkage_safety', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:567: tool_req__docs_arch_link_qm_to_safety_req.satisfies (['PROCESS_gd_req__arch_linkage_requirement', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.
requirements/requirements.rst:579: tool_req__docs_req_arch_link_safety_to_arch.satisfies (['PROCESS_gd_req__arch_linkage_safety_trace', 'PROCESS_gd_req__req_linkage_safety', 'tool_req__docs_metamodel']): does not follow pattern `^gd_req__.*$`.

New:

=========== 32 non-fatal warnings (will become fatal in the future) ============
requirements/requirements.rst:634: tool_req__docs_dd_link_source_code_link: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:96: tool_req__docs_common_attr_title: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:126: tool_req__docs_common_attr_desc_wording: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:793: tool_req__docs_stdreq_types: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:784: tool_req__docs_wf_types: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:353: tool_req__docs_req_types: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:199: tool_req__docs_common_attr_status: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:434: tool_req__docs_req_link_satisfies_allowed: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:257: tool_req__docs_doc_types: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:270: tool_req__docs_doc_attr: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:765: tool_req__docs_tvr_status: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:738: tool_req__docs_tvr_safety: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:751: tool_req__docs_tvr_security: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:382: tool_req__docs_req_attr_reqtype: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:173: tool_req__docs_common_attr_safety: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:373: tool_req__docs_req_attr_rationale: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:148: tool_req__docs_common_attr_security: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:397: tool_req__docs_req_attr_reqcov: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:412: tool_req__docs_req_attr_testcov: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:478: tool_req__docs_arch_types: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:605: tool_req__docs_arch_views: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:807: tool_req__docs_saf_types: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:920: tool_req__docs_saf_attr_dfa_failure_id: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:850: tool_req__docs_saf_attrs_sufficient: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:874: tool_req__docs_saf_attrs_content: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:886: tool_req__docs_saf_attrs_violates: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:839: tool_req__docs_saf_attrs_mitigation_issue: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:824: tool_req__docs_saf_attrs_mitigated_by: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:907: tool_req__docs_saf_attr_fmea_fault_id: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:462: tool_req__docs_common_attr_safety_link_check: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:567: tool_req__docs_arch_link_qm_to_safety_req: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).
requirements/requirements.rst:579: tool_req__docs_req_arch_link_safety_to_arch: references tool_req__docs_metamodel as satisfies, but it must reference Process Requirements (gd_req).

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 49b8a827-ee82-4eb6-b2f0-c91a3e9d5f1d
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (62 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (108 packages loaded, 255 targets configured)

Analyzing: target //src:license-check (129 packages loaded, 2435 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[8 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 14.039s, Critical Path: 0.31s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@AlexanderLanin AlexanderLanin marked this pull request as ready for review September 26, 2025 06:49
Copilot AI review requested due to automatic review settings September 26, 2025 06:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error message formatting in metamodel validation by making warnings more human-readable and converting string-based need type references to actual ScoreNeedType objects for better type checking.

  • Replaces cryptic regex pattern warnings with descriptive messages about required reference types
  • Converts string-based need type references in YAML configuration to typed object references
  • Adds postprocessing logic to resolve need type names to actual ScoreNeedType objects at runtime

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/extensions/score_metamodel/yaml_parser.py Updates function signature to use more specific type annotation
src/extensions/score_metamodel/tests/rst/options/test_options_options.rst Updates expected test output format for new error messages
src/extensions/score_metamodel/metamodel_types.py Adds union types to support both regex strings and ScoreNeedType lists for links
src/extensions/score_metamodel/metamodel.yaml Converts string need type references to comma-separated type names
src/extensions/score_metamodel/checks/check_options.py Implements new error logging with descriptive messages and type resolution
src/extensions/score_metamodel/init.py Adds postprocessing to convert type name strings to ScoreNeedType objects
Comments suppressed due to low confidence (1)

src/extensions/score_metamodel/checks/check_options.py:1

  • This assertion suggests temporary code. Replace with proper type checking or error handling, especially since the type hints indicate this function should handle both strings and lists.
# *******************************************************************************

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexanderLanin AlexanderLanin merged commit edc9f4e into main Sep 26, 2025
13 checks passed
@AlexanderLanin AlexanderLanin deleted the meta branch September 26, 2025 08:43
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Sep 26, 2025
sameer6989 pushed a commit to esrlabs/score_docs-as-code that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants