Skip to content

update metamodel to follow process requirements #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexanderLanin merged 3 commits into from
Oct 7, 2025
Merged

update metamodel to follow process requirements #263

AlexanderLanin merged 3 commits into from
Oct 7, 2025

Conversation

@antonkri
Copy link
Contributor

@antonkri antonkri commented Sep 26, 2025 •
edited
Loading

📌 Description

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 7d0ff903-9ad9-4ec0-b682-3019e4564989
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (69 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (122 packages loaded, 1593 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[5 / 12] Writing repo mapping manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool]; 0s local
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 14.150s, Critical Path: 0.35s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@AlexanderLanin
Copy link
Member

AlexanderLanin commented Sep 26, 2025

Unfortunately we cannot apply changes, as long as examples in process repo violate them.

folder_templates/features/feature_name/architecture/index.rst:139: WARNING: comp_arc_sta__feature_name__component_name: is missing required link: fulfils. [score_metamodel]
folder_templates/modules/module_name/component_name/docs/architecture/index.rst:114: WARNING: comp_arc_sta__component_name__2: is missing required link: fulfils. [score_metamodel]

@antonkri
Copy link
Contributor Author

antonkri commented Sep 26, 2025

Unfortunately we cannot apply changes, as long as examples in process repo violate them.

folder_templates/features/feature_name/architecture/index.rst:139: WARNING: comp_arc_sta__feature_name__component_name: is missing required link: fulfils. [score_metamodel]
folder_templates/modules/module_name/component_name/docs/architecture/index.rst:114: WARNING: comp_arc_sta__component_name__2: is missing required link: fulfils. [score_metamodel]

Thanks god we have CI, I will fix it

@antonkri antonkri force-pushed the ankr_update_metamodel branch from 156e697 to 6fc11ca Compare September 30, 2025 13:05
@antonkri antonkri force-pushed the ankr_update_metamodel branch from 6fc11ca to 750a2eb Compare September 30, 2025 13:06
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

The created documentation from the pull request is available at: docu-html

@AlexanderLanin AlexanderLanin mentioned this pull request Sep 30, 2025
Open
@AlexanderLanin
Copy link
Member

AlexanderLanin commented Oct 7, 2025 •
edited
Loading

This PR probably addresses this topic: #268 (review) as addressed by @aschemmel-tech

@aschemmel-tech aschemmel-tech mentioned this pull request Oct 7, 2025
Merged
6 tasks
a-zw
a-zw reviewed Oct 7, 2025
View reviewed changes
MODULE.bazel Outdated
module_name = "score_process",
remote = "https://github.com/eclipse-score/process_description.git",
commit = "5c4c11df4af3d48592f15d26c70a11c82a38402b", # trlc-2.0.2 release
)
Copy link
Contributor

@a-zw a-zw Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is a git override necessary here??

Copy link
Contributor

@a-zw a-zw Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried building without the override and got these errors:

folder_templates/features/feature_name/architecture/index.rst:139: WARNING: comp_arc_sta__feature_name__component_name: is missing required link: `fulfils`. [score_metamodel]
folder_templates/modules/module_name/component_name/docs/architecture/index.rst:114: WARNING: comp_arc_sta__component_name__2: is missing required link: `fulfils`. [score_metamodel]

So it seems to be about the fundamental problem that docs-as-code and score_process have a circular dependency. I created #272 for this.

Now we need to quicker fix for this change. We could leave fulfils optional for now.

src/extensions/score_metamodel/metamodel.yaml
status: ^(valid|invalid)$
mandatory_links:
includes: ^logic_arc_int(_op)*__.+$
optional_links:
Copy link
Contributor

@a-zw a-zw Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! According to tool_req__docs_arch_link_fulfils this should have been mandatory already.

The other changes to the metamodel also match the current requirements imho.

a-zw
a-zw reviewed Oct 7, 2025
View reviewed changes
src/extensions/score_metamodel/metamodel.yaml
optional_links:
includes: logic_arc_int_op
fulfils: comp_req
fulfils: feat_req
Copy link
Contributor

@a-zw a-zw Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also requires a corresponding change in tool_req__docs_arch_link_fulfils.

@a-zw a-zw mentioned this pull request Oct 7, 2025
Merged
6 tasks
a-zw and others added 2 commits October 7, 2025 14:05
@a-zw
update metamodel to follow process requirements (#273)
3264c65 
* Undo git-override

Due to a circular dependency this implies a certain fulfils link is
still optional until score_process documents are fixed.

* Adapt requirement to process/metamodel change
@AlexanderLanin
Merge branch 'main' into ankr_update_metamodel
4ac1dc3
@AlexanderLanin AlexanderLanin merged commit eb09154 into main Oct 7, 2025
13 checks passed
@AlexanderLanin AlexanderLanin deleted the ankr_update_metamodel branch October 7, 2025 20:28
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderLanin AlexanderLanin AlexanderLanin approved these changes

@MaximilianSoerenPollak MaximilianSoerenPollak Awaiting requested review from MaximilianSoerenPollak MaximilianSoerenPollak is a code owner

@dcalavrezo-qorix dcalavrezo-qorix Awaiting requested review from dcalavrezo-qorix dcalavrezo-qorix is a code owner

+1 more reviewer

@a-zw a-zw a-zw left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Infrastructure
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonkri @AlexanderLanin @a-zw