-
Notifications
You must be signed in to change notification settings - Fork 19
modify description of architecture types and fix drawing #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the documentation and metamodel to clarify the distinction between architecture elements and architecture views. The main focus is on refining how component and feature types are categorized and described, along with a fix to the drawing logic.
Key changes:
- Updated documentation to distinguish architecture elements (feat, comp, mod, etc.) from architecture views (feat_arc_sta, comp_arc_sta, etc.)
- Modified metamodel configuration to change mod_view_sta includes from mandatory comp_arc_sta to optional comp and comp_arc_sta
- Updated drawing logic to filter for comp type instead of comp_arc_sta
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test_prohibited_words.rst | Updated comment to clarify feat_arc_sta is an architecture view |
| metamodel.yaml | Changed comment from "Architecture Element & View" to "Architecture View" and modified mod_view_sta includes configuration |
| init.py | Changed type filter from comp_arc_sta to comp in draw_comp_incl_impl_int function |
| requirements.rst | Updated architecture element list to show comp instead of comp_arc_sta, added mod as element, and clarified note about architecture views |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
📌 Description
Change description of architecture elements in documentation and ix draw of architecture picture
🚨 Impact Analysis
✅ Checklist