Skip to content

score_tooling: Switch and update #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vinodreddy-g merged 1 commit into from
Nov 3, 2025
Merged

score_tooling: Switch and update #155

vinodreddy-g merged 1 commit into from
Nov 3, 2025

Conversation

@umaucher
Copy link
Contributor

@umaucher umaucher commented Oct 29, 2025

Switch to the module bundling various score tools score_tooling 1.0.2. Remove handling of the previous individual used ones:

  • score_cli_helper
  • score_cr_checker
  • score_dash_license_checker
  • score_format_checker
  • score_starpls_lsp

@umaucher
score_tooling: Switch and update
34df7f3 
Switch to the module bundling various score tools score_tooling 1.0.2. Remove
handling of the previous individual used ones:
- score_cli_helper
- score_cr_checker
- score_dash_license_checker
- score_format_checker
- score_starpls_lsp
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 22409167-8c08-4966-9685-ca930c1edb92
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-iKHWUIBrUN/fFOCltkTmHfDcKw0h4ZVmP7NVSoc8zBs="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.15.0, but got googletest@1.17.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'platforms', the root module requires module version platforms@0.0.11, but got platforms@1.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (79 packages loaded, 9 targets configured)

Analyzing: target //:license-check (86 packages loaded, 13 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2286 targets configured)

Analyzing: target //:license-check (153 packages loaded, 2901 targets configured)

Analyzing: target //:license-check (153 packages loaded, 2901 targets configured)

Analyzing: target //:license-check (156 packages loaded, 4908 targets configured)

Analyzing: target //:license-check (156 packages loaded, 4908 targets configured)

DEBUG: Rule 'toolchains_llvm++llvm+llvm_toolchain_llvm' indicated that a canonical reproducible form can be obtained by modifying arguments _action_listener = <unknown object com.google.devtools.build.lib.packages.Attribute$LabelListLateBoundDefault>, _config_dependencies = [], _configure = False, _environ = [], _original_name = "llvm_toolchain_llvm"
DEBUG: Repository toolchains_llvm++llvm+llvm_toolchain_llvm instantiated at:
  <builtin>: in <toplevel>
Repository rule llvm defined at:
  /home/runner/.bazel/external/toolchains_llvm+/toolchain/rules.bzl:27:23: in <toplevel>
INFO: Analyzed target //:license-check (157 packages loaded, 6843 targets configured).
[7 / 14] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 65 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[13 / 14] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 202.146s, Critical Path: 1.29s
INFO: 14 processes: 3 disk cache hit, 9 internal, 1 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

The created documentation from the pull request is available at: docu-html

@umaucher umaucher marked this pull request as ready for review October 29, 2025 15:47
arkjedrz
arkjedrz suggested changes Oct 30, 2025
View reviewed changes
MODULE.bazel
bazel_dep(name = "score_format_checker", version = "0.1.1")
bazel_dep(name = "aspect_rules_lint", version = "1.4.4")
bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
# ToDo: implicit dependencies for score_tooling, but needed directly here??
Copy link
Contributor

@arkjedrz arkjedrz Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle before merge, either by a fix or by providing a link to an issue.

Copy link
Contributor Author

@umaucher umaucher Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: eclipse-score/tooling#82

Copy link
Contributor

@arkjedrz arkjedrz Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> TODO: implicit dependencies for score_tooling shouldn't be needed here: https://github.com/eclipse-score/tooling/issues/82

arkjedrz
arkjedrz approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@arkjedrz arkjedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue reported, otherwise LGTM.

MODULE.bazel
bazel_dep(name = "score_format_checker", version = "0.1.1")
bazel_dep(name = "aspect_rules_lint", version = "1.4.4")
bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
# ToDo: implicit dependencies for score_tooling, but needed directly here??
Copy link
Contributor

@arkjedrz arkjedrz Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> TODO: implicit dependencies for score_tooling shouldn't be needed here: https://github.com/eclipse-score/tooling/issues/82

@vinodreddy-g vinodreddy-g merged commit 5164090 into eclipse-score:main Nov 3, 2025
13 checks passed
@umaucher umaucher mentioned this pull request Nov 3, 2025
Open
atarekra pushed a commit to Valeo-S-CORE-Organization/persistency that referenced this pull request Nov 9, 2025
@umaucher
score_tooling: Switch and update (eclipse-score#155)
ce45f02 
Switch to the module bundling various score tools score_tooling 1.0.2. Remove
handling of the previous individual used ones:
- score_cli_helper
- score_cr_checker
- score_dash_license_checker
- score_format_checker
- score_starpls_lsp
@umaucher umaucher deleted the um_score_tooling branch November 12, 2025 14:38
Saumya-R pushed a commit to qorix-group/persistency that referenced this pull request Nov 19, 2025
@umaucher @Saumya-R
score_tooling: Switch and update (eclipse-score#155)
75d2bd3 
Switch to the module bundling various score tools score_tooling 1.0.2. Remove
handling of the previous individual used ones:
- score_cli_helper
- score_cr_checker
- score_dash_license_checker
- score_format_checker
- score_starpls_lsp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinodreddy-g vinodreddy-g vinodreddy-g approved these changes

+1 more reviewer

@arkjedrz arkjedrz arkjedrz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@umaucher @arkjedrz @vinodreddy-g