Skip to content

Conversation

@aschemmel-tech
Copy link
Contributor

Ref: Resolves #117

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

:complies: std_req__iso26262__support_1045

Documents headers shall contain an "author" attribute. Every committer who adds more than 50%
Generic documents headers shall contain an "author" attribute. Every committer who adds more than 50%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From mathematical point of you, if 2 authors add exactly 50%, nobody will be an author, so I think this criteria must be redefined

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also unclear to us how this is calculated.

How exactly are the 50% defined? Is it per commit? Only when the PR is ready and then all commits together?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From mathematical point of you, if 2 authors add exactly 50%, nobody will be an author, so I think this criteria must be redefined

Ok, will try a new definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also unclear to us how this is calculated.

How exactly are the 50% defined? Is it per commit? Only when the PR is ready and then all commits together?

I thought per Document line after the PR merge. Will try to better explain.

:complies: std_req__iso26262__support_745, std_req__aspice_40__SUP-8-BP8

The structured text tool shall check that the Id's of the configuration items are unique.
The doc-as-code tool shall check that the Id's of the configuration items (documented in doc-as-code) are unique.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This I still don't quiet understand.

Is it the needs in docs-as-code that map to the ones in doc_concept?
So ASPICE_40, ISO26262 etc.?
Or is it something else?

Copy link
Contributor Author

@aschemmel-tech aschemmel-tech Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition in configuration_concept.rst is: "configuration items are all realizations of defined work products in the project ..." and here we say "which are documented as sphinx-needs". The work products are defined in <process_name_>workproduct.rst files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so work products are realized we the need document, having attribute realizes Process_wp_ ...., or doc_tool, they shall have all unique IDs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this applies specifically to Generic documents?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it the list from gd_req__config__workproducts_storage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this applies specifically to Generic documents?

No, all work producs which are realized as needs (Requirements, Architecture, Generic Documents ...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it the list from gd_req__config__workproducts_storage?

The Unique ID for files which do not contain needs, like all sources I would not consider here. For me this is the full path name. Honestly I am unsure if we should define a requirement that requires a check that checks for duplicates of SW and tools which we pull from outside the project, avoiding the use of different versions.

@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-process-reqs-fixes branch 3 times, most recently from e6aaa88 to cd108da Compare July 22, 2025 09:49
@aschemmel-tech
Copy link
Contributor Author

masc2023
masc2023 previously approved these changes Jul 22, 2025
@aschemmel-tech aschemmel-tech merged commit 8fd8d55 into main Jul 23, 2025
5 checks passed
@aschemmel-tech aschemmel-tech deleted the aschemmel-tech-process-reqs-fixes branch July 23, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Questions regarding Process Requirements

5 participants