improve pytest xml output #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves pytest XML output configuration and adds development environment settings. The changes focus on enhancing test execution by configuring proper XML output for Bazel integration and preventing pytest from searching irrelevant directories.
- Added
--junitxmlargument to generate XML output compatible with Bazel's test result schema - Configured
norecursedirsin pytest.ini to prevent searching in hidden folders and build directories - Added VS Code workspace settings for Python development
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python_basics/score_pytest/pytest.ini | Added norecursedirs configuration to exclude irrelevant directories from test discovery |
| python_basics/score_pytest/py_pytest.bzl | Enhanced args formatting and added --junitxml flag for XML output generation |
| .vscode/settings.json | Added VS Code workspace settings for Python development environment |
| # XML_OUTPUT_FILE: Location to which test actions should write a test | ||
| # result XML output file. Otherwise, Bazel generates a default XML | ||
| # output file wrapping the test log as part of the test action. The XML | ||
| # schema is based on the JUnit test result schema. |
There was a problem hiding this comment.
The comment explains XML_OUTPUT_FILE but doesn't clarify why double dollar signs (
Suggested change
| # schema is based on the JUnit test result schema. | |
| # schema is based on the JUnit test result schema. | |
| # Note: Double dollar signs ($$) are used for Bazel variable expansion | |
| # to distinguish it from shell variable expansion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.