fix: align viewWelcome to VS Code
#14391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: eclipse-theia#14309 Ref: arduino/arduino-ide#2543 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
rschnekenbu
approved these changes
Nov 7, 2024
Contributor
rschnekenbu
left a comment
rschnekenbu
left a comment
There was a problem hiding this comment.
Looking good to me, Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Aligns the
viewWelcomebehavior to VS Code.BREAKING:
renderCommandLinkNodetorenderLinkNodeisEnabledClickgets a raw when context expression instead of a URLstringHow to test
See how to use it: https://github.com/dankeboy36/eclipse-theia-14309/tree/main?tab=readme-ov-file#eclipse-theia-14309-readme.
VSIX: https://github.com/dankeboy36/eclipse-theia-14309/raw/refs/heads/main/eclipse-theia-14309-0.0.1.vsix
VS Code:
Screen.Recording.2024-11-03.at.13.41.04.mov
Theia:
Screen.Recording.2024-11-03.at.13.37.45.mov
Closes: #14309
Ref: arduino/arduino-ide#2543
Follow-ups
Review checklist
Reminder for reviewers