Boot Record and FSINFO Signature Corrections#59
Merged
fdesbiens merged 2 commits intoeclipse-threadx:devfrom Jun 10, 2025
Merged
Boot Record and FSINFO Signature Corrections#59fdesbiens merged 2 commits intoeclipse-threadx:devfrom
fdesbiens merged 2 commits intoeclipse-threadx:devfrom
Conversation
Correction to boot record signature writing; attempted to bring in line with design intent of variable length boot record as used earlier in function.
Correction of FSINFO trail signature in format function
Contributor
|
@eclipse-threadx/iot-threadx-committers, I need a volunteer with porting expertise to review this contribution. |
|
Is rhere is backwsrd compatibility issue here? |
rahmanih
approved these changes
Mar 18, 2025
Contributor
rahmanih
left a comment
rahmanih
left a comment
There was a problem hiding this comment.
Tested and it is working fine.
to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected placement of boot signature in case of FX_FORCE_512_BYTE_BOOT_SECTOR being defined; brought in line with location mentioned earlier in the same file. Also switched from 'magic numbers' to extant macros.
Also corrected placement of FSINFO trail signature, which was found to be incorrect by coran21 (in issue #47 ).