Skip to content

CMake fixes#132

Merged
obgm merged 2 commits intoeclipse-tinydtls:developfrom
bosch-io:cmake_fixes
May 20, 2022
Merged

CMake fixes#132
obgm merged 2 commits intoeclipse-tinydtls:developfrom
bosch-io:cmake_fixes

Conversation

@boaks
Copy link
Copy Markdown
Contributor

@boaks boaks commented May 12, 2022

Based on the initial PR #18 this PR adds support for getrandom and libcunit.
Also adds license headers and applies minor fixes.
Amend README.md with instructions to use cmake.

Signed-off-by: Jimmy Björklund <jimmy.bjorklund@hotmail.se>
@boaks
Copy link
Copy Markdown
Contributor Author

boaks commented May 12, 2022

Hi @obgm ,

according your comment

The major obstacle is that we would need someone who is willing to work on this, i.e., keep it in sync and functionally equivalent to the configure/make mechanism.

Generally it's not to hard to maintain cmake, especially, if it's marked as experimental.
Most header, function or field checks have their equivalent in cmake. That stuff is isolated in "AutoConf.cmake" and "dtls_config.h.cmake.in".

Though it's also the base for a zephyr port, I would appreciate, if you review it, (optional) test it, and then merge it.

@boaks boaks mentioned this pull request May 12, 2022
@boaks boaks force-pushed the cmake_fixes branch 2 times, most recently from f106489 to 95f92a8 Compare May 12, 2022 15:42
Copy link
Copy Markdown
Contributor

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently trying out the CMake support in the context of #126 and noticed that adjustments for the .gitignore file are currently missing.

So far, I came up with the following:

# CMake

CMakeCache.txt
cmake_install.cmake
CMakeFiles

Do you think there is anything missing?

Another aspect concerns static vs. dynamic linking, see the comment below.

Comment thread CMakeLists.txt
@boaks
Copy link
Copy Markdown
Contributor Author

boaks commented May 13, 2022

Add the new cmake temporary files to .gitignore.
(If a separate build directory is used, these temporary files will also be outside of git working tree.)

Add also license headers and apply minor fixes.
Append version to shared library on install.
Amend README.md with instructions to use cmake.

Signed-off-by: Achim Kraus <achim.kraus@bosch.io>
@boaks
Copy link
Copy Markdown
Contributor Author

boaks commented May 14, 2022

I've tested the install and extended it with the version for shared libraries.

@obgm
Copy link
Copy Markdown
Contributor

obgm commented May 20, 2022

Thanks, @JimmyBjorklund @boaks and @JKRhb for making this happen.

@obgm obgm merged commit e4d547c into eclipse-tinydtls:develop May 20, 2022
@obgm obgm mentioned this pull request May 20, 2022
@boaks boaks deleted the cmake_fixes branch May 23, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants