Conversation
Signed-off-by: Jimmy Björklund <jimmy.bjorklund@hotmail.se>
|
Hi @obgm , according your comment
Generally it's not to hard to maintain cmake, especially, if it's marked as experimental. Though it's also the base for a zephyr port, I would appreciate, if you review it, (optional) test it, and then merge it. |
f106489 to
95f92a8
Compare
JKRhb
left a comment
There was a problem hiding this comment.
I am currently trying out the CMake support in the context of #126 and noticed that adjustments for the .gitignore file are currently missing.
So far, I came up with the following:
# CMake
CMakeCache.txt
cmake_install.cmake
CMakeFiles
Do you think there is anything missing?
Another aspect concerns static vs. dynamic linking, see the comment below.
|
Add the new cmake temporary files to .gitignore. |
Add also license headers and apply minor fixes. Append version to shared library on install. Amend README.md with instructions to use cmake. Signed-off-by: Achim Kraus <achim.kraus@bosch.io>
|
I've tested the install and extended it with the version for shared libraries. |
|
Thanks, @JimmyBjorklund @boaks and @JKRhb for making this happen. |
Based on the initial PR #18 this PR adds support for getrandom and libcunit.
Also adds license headers and applies minor fixes.
Amend README.md with instructions to use cmake.