Pull in changes from up-core-api 1.5.7#21
Merged
neelam-kushwah merged 4 commits intoeclipse-uprotocol:mainfrom Apr 6, 2024
Merged
Pull in changes from up-core-api 1.5.7#21neelam-kushwah merged 4 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah merged 4 commits intoeclipse-uprotocol:mainfrom
Conversation
* Add Notification UMessageType * Add isShortForm() * Various Fixes * 100% Code Coverage * Added Linter and Coverage checker to build Co-Authored-By: Patrick Yang <47698870+hostilechild007@users.noreply.github.com> Co-Authored-By: Neelam Kushwah <7788957+neelam-kushwah@users.noreply.github.com>
Contributor
Author
neelam-kushwah
requested changes
Apr 4, 2024
Contributor
neelam-kushwah
left a comment
neelam-kushwah
left a comment
There was a problem hiding this comment.
Bump the version to 0.1.2-dev
Contributor
neelam-kushwah
left a comment
neelam-kushwah
left a comment
There was a problem hiding this comment.
How are you ensuring code coverage? Is there a way we can generate reports similar to what we do in Java? Let's explore this.
The Linter I had (flake8) is not as robust as the linter we want to use (pylint), so I will be removing the workflow with flake8 for now. We will be creating an issue which will integrate pylint and better coverage testing.
neelam-kushwah
requested changes
Apr 6, 2024
Originally, I had UTC references from datetime library in a few of my tests. I remember them working, but when I ran again, they weren't working anymore. So, I switched to timezone in datetime which seems to work well. Also, my multimethod implementations were a bit redundant in places, so I cleaned those up.
neelam-kushwah
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.