Add validate_id, micro_uri range, etc#30
Merged
neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom Apr 26, 2024
Merged
Add validate_id, micro_uri range, etc#30neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom
Conversation
* Add validation for id property in uattributes * Check ranges for Micro URI and add missing test coverage * Check UAuthority and UResource names are not blank These changes follow the changes made in up-java since 1.5.7 was released.
Contributor
Author
|
Code coverage report is ready! 📈
|
neelam-kushwah
approved these changes
Apr 26, 2024
Contributor
neelam-kushwah
left a comment
neelam-kushwah
left a comment
There was a problem hiding this comment.
Most of the changes are due to formatting. Other changes related to ID validation and micro URI range look good to me.
Contributor
|
@matthewd0123 Can you bump the version to 0.1.3-dev |
Bump version of up-python from 0.1.2-dev to 0.1.3-dev
Contributor
Author
done |
|
Code coverage report is ready! 📈
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes follow the changes made in up-java since 1.5.7 was released.