Initial commit of up-L2 Communication Layer Apis#44
Merged
neelam-kushwah merged 10 commits intoeclipse-uprotocol:mainfrom Jul 4, 2024
Merged
Initial commit of up-L2 Communication Layer Apis#44neelam-kushwah merged 10 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah merged 10 commits intoeclipse-uprotocol:mainfrom
Conversation
neelam-kushwah
force-pushed
the
communication-layer
branch
9 times, most recently
from
1fbf1bd to
e361890
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
communication-layer
branch
from
c6384ca to
a48d0c7
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
communication-layer
branch
2 times, most recently
from
a2ad1d7 to
4323395
Compare
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
Co-Authored-By: Matthew D'Alonzo <matthewdalonzo@gmail.com>
The following change removes the v8 custom UUID to the v7 standard definition per up-spec change eclipse-uprotocol/up-spec#170
neelam-kushwah
force-pushed
the
communication-layer
branch
from
061ba03 to
def1b0c
Compare
neelam-kushwah
force-pushed
the
communication-layer
branch
2 times, most recently
from
eae9ea1 to
64c0e73
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
communication-layer
branch
3 times, most recently
from
6f08471 to
64c0e73
Compare
neelam-kushwah
force-pushed
the
communication-layer
branch
3 times, most recently
from
bf90333 to
af35fd6
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
communication-layer
branch
2 times, most recently
from
04685b9 to
53c5771
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
communication-layer
branch
from
53c5771 to
2964fc6
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
communication-layer
branch
from
2964fc6 to
accdb86
Compare
|
Code coverage report is ready! 📈
|
stevenhartley
requested changes
Jul 4, 2024
uprotocol/communication/rpcresult.py
Outdated
| return default_value() | ||
| return default_value | ||
|
|
||
| def map(self, f: Callable[[T], T]) -> RpcResult: |
There was a problem hiding this comment.
are these needed? I know they are in Java so we can use them in a stream but are they needed in Python?
Contributor
Author
There was a problem hiding this comment.
I will remove the unused parts in the next PR after checking the simulator code.
neelam-kushwah
force-pushed
the
communication-layer
branch
from
accdb86 to
01ad487
Compare
neelam-kushwah
force-pushed
the
communication-layer
branch
from
01ad487 to
9f94210
Compare
neelam-kushwah
force-pushed
the
communication-layer
branch
3 times, most recently
from
3805ca9 to
831f7b4
Compare
neelam-kushwah
force-pushed
the
communication-layer
branch
from
831f7b4 to
83bade5
Compare
|
Code coverage report is ready! 📈
|
stevenhartley
approved these changes
Jul 4, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
LGTM, more testing is needed but that can be done on subsequent PR changes
This was
linked to
issues
Jul 31, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45 , #43