Update all L2 APIs to return responses asynchronously.#48
Merged
neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom Jul 10, 2024
Merged
Update all L2 APIs to return responses asynchronously.#48neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom
Conversation
|
Code coverage report is ready! 📈
|
matthewd0123
reviewed
Jul 8, 2024
|
Code coverage report is ready! 📈
|
matthewd0123
approved these changes
Jul 8, 2024
Contributor
|
LGTM |
stevenhartley
approved these changes
Jul 10, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
LGTM. One thing I notice is that all the tests seem to run each operation synchronously by calling await. Is there a way you can test operations happening concurrently to ensure they are sequenced correctly?
Contributor
Author
|
yes, we can use asyncio.gather() to run multiple functions concurrently. I will add a test case in each file with asyncio.gather to ensure our tests cover concurrent operations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates all the communication layer APIs to return UStatus asynchronously. Methods now return UStatus upon success or complete with a UStatusError containing the relevant UStatus information upon failure