In-Memory Subscriber functionality#52
Merged
neelam-kushwah merged 4 commits intoeclipse-uprotocol:mainfrom Jul 16, 2024
Merged
Conversation
Implemented the client-side functionality for the uSubscription service communication, enabling the ability to subscribe and unsubscribe to topics. This update also manages various subscription states and handles subscription change notifications
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
matthewd0123
force-pushed
the
subscriber
branch
2 times, most recently
from
69f3d80 to
e0b40df
Compare
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
subscriber
branch
from
8c8cfc6 to
5d54350
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
subscriber
branch
6 times, most recently
from
cc3fbfa to
2d52c2d
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
subscriber
branch
from
cdbdc2c to
8a01d8a
Compare
|
Code coverage report is ready! 📈
|
| self.notification_handler: UListener = MyNotificationListener(self.handlers) | ||
| self.is_listener_registered = False | ||
| service_descriptor = usubscription_pb2.DESCRIPTOR.services_by_name["uSubscription"] | ||
| self.notification_uri = UriFactory.from_proto(service_descriptor, 0x8000) |
Contributor
There was a problem hiding this comment.
Fine for now probably, but would be good I think not to have these vals hardcoded
Contributor
Author
There was a problem hiding this comment.
Will do it later as it requires parsing the proto
Contributor
|
Opened #55 to handle in a future PR |
ankitmehta03
suggested changes
Jul 15, 2024
ankitmehta03
left a comment
ankitmehta03
left a comment
There was a problem hiding this comment.
Update Readme to remove examples showing uTransport = MagicMock, instead we can specify a comment saying "uTransport instance"
|
Code coverage report is ready! 📈
|
Modified test cases, update READMEs and added examples to the README files
neelam-kushwah
force-pushed
the
subscriber
branch
2 times, most recently
from
486d19b to
b78f750
Compare
|
Code coverage report is ready! 📈
|
neelam-kushwah
force-pushed
the
subscriber
branch
from
b78f750 to
218937a
Compare
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
stevenhartley
approved these changes
Jul 16, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
Minor comments but nothing to hold off the merge
| @@ -0,0 +1,157 @@ | |||
| = uProtocol Communication Layer | |||
There was a problem hiding this comment.
Suggested change
| = uProtocol Communication Layer | |
| = uProtocol Communication Layer (uP-L2) |
This was
linked to
issues
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53 , #54