Errors in tsx since upgrading to 1.0.0

[stephanpelikan]

Since upgrading to 1.0.0 (using Eclipse 4.25.0) I see these errors in my React tsx files:

In one file of my project, after working on other issues, this error is permanently gone without following the advice to add the import. All other tsx files I open show that error.

How can I get rid of this?

I see also other errors which were also suddenly highlighted after upgrading to 1.0.0. Some of them are right and need to be resolved. But why they were not highlighted before?

Additionally, the production build does not highlight those "new" errors.

I'm using
"typescript": "^4.7.4"
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-jsx": "^1.0.0",
and this is my tsconfig.json

{
  "compilerOptions": {
    "target": "es6",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "baseUrl": "src/",
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noFallthroughCasesInSwitch": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "react-jsx",
    "sourceMap": true
  },
  "include": [
    "./src/**/*.ts"
  ],
  "exclude": [
    "node_modules",
    "build"
  ]
}

[mickaelistria]

Some of them are right and need to be resolved. But why they were not highlighted before?

Wild Web Developer uses the typescript-language-server to provide analysis. And this (and its transitive dependencies) gets updates frequently. Some updates bring new features.

[stephanpelikan]

Ok, were I can find the from which to what version of language-server this 1.0.0 upgrade brings in?
I found a similar issue there (typescript-language-server/typescript-language-server#150) and they ask for detail informtion: Where can I found what is used in case wildwebdevelopers?

[mickaelistria]

Ok, were I can find the from which to what version of language-server this 1.0.0 upgrade brings in?

in the install location, eclipse/plugins/org.eclipse.wildwebdeveloper_*/package-lock.json.

I found a similar issue there (typescript-language-server/typescript-language-server#150) and they ask for detail informtion

Thanks, this is very relevant! Indeed "client doesn't set languageId correctly". this needs to be fixed in Wild Web Developer. The fix would be similar to 1ed945d#diff-39186773eb7c359cf334445a924d91bdb589ea566a6eba995f06cdf7af1e7d18 but applied to the jsts language server binding. Would you be interested in trying to submit a fix as a PR?

[stephanpelikan]

I can try, but I don't have a setup for this - so someone has to review und test the changes.

By-the-way: In the error-log I found this line

org.eclipse.lsp4e
Info
Wed Nov 30 12:52:40 CET 2022
[Info]	[lspserver] Using Typescript version (bundled) 4.8.4 from path "/home/dev/Development/ides/eclipse/plugins/org.eclipse.wildwebdeveloper_1.0.0.202211030226/node_modules/typescript/lib/tsserver.js"

Might it be, that this is the reason for the new errors I see? As far as I could figure out previously typescript 4.6.4 was bundled and I'm using 4.7.4 in my package.json. If the new version 4.8.4 used by WWD 1.0.0 shows stuff as an error which wasn't an error before would be a possible explaination.

So, I asked myself why is the bundled version of typescript used and not the version of my project. Typescript is evolving fast and it is a common situation on customers projects to fix bugs or implement minor features without upgrading the entire code base due to a newer typescript version. I do Java/Maven-based projects and I use maven-frontend-plugin to avoid this situation at build-time. It would be great to avoid this also at edit-time!

For example: If the project's tsserver.js could be used by scanning the right path-hierarchy of a ts-file opened until the next package.json is found (e.g. {projectRoot}/src/components/MyAwesomeComponent.ts> {projectRoot}/package.json or for Java/Maven-based projects as I do {projectRoot}/src/main/webapp/src/components/MyAwesomeComponent.ts > {projectRoot}/src/main/webapp/package.json).

[mickaelistria]

I can try, but I don't have a setup for this - so someone has to review und test the changes.

Please submit a PR, I'll try to test it.

[stephanpelikan]

As far as I understand, this is already in place:

https://github.com/eclipse/wildwebdeveloper/blob/1ed945dde0501136c5be7e2aabd65c908afd39c5/org.eclipse.wildwebdeveloper/plugin.xml#L553

Sorry, if I'm wrong and didn't get it. Since this is already fixed in 1.0.1 I updated but now I get other errors:

Unfortunately, the previous problems were solveable by just adding an import. This one I need to investigate what that means and how to workaround. I guess, I will try to downgrade the WWD because all that stuff blocks me. I tried to upgrade typescript in my package.json but it compiles well - no errors. If this new error is caused by the next typescript upgrade to 4.9.4 according to he Changelog, then I really vote for project-specific typescript versions.

[stephanpelikan]

I googled for this error and 90% is about "rename file from .ts to .tsx" but in my case it is already .tsx and it worked with WWD 1.0.0

[sinhote]

I have the same issue. I guess not so many people is using Eclipse for tsx development :S

As far as I understand, this is already in place:

https://github.com/eclipse/wildwebdeveloper/blob/1ed945dde0501136c5be7e2aabd65c908afd39c5/org.eclipse.wildwebdeveloper/plugin.xml#L553

Sorry, if I'm wrong and didn't get it. Since this is already fixed in 1.0.1 I updated but now I get other errors:

Unfortunately, the previous problems were solveable by just adding an import. This one I need to investigate what that means and how to workaround. I guess, I will try to downgrade the WWD because all that stuff blocks me. I tried to upgrade typescript in my package.json but it compiles well - no errors. If this new error is caused by the next typescript upgrade to 4.9.4 according to he Changelog, then I really vote for project-specific typescript versions.

The same is happening for me with Eclipse 2022-09 and Wild Web Developer with the following versions:

@stephanpelikan did you find a workaround?

[stephanpelikan]

Unfortunately not. I downgraded the plugin. Meanwhile I had a bunch of updates and my current version is

which is working fine. Since I need a running IDE without worries I do not update any more. Maybe in future I will give it another try.

Independent from this, Wild Web Developer uses that bundled typescript version instead of the version given in each project's package.json. As long as your projects do fine with this its OK, but especially maintaining older code is a problem. So, at the moment the setup and the projects I'm working on are matching fine, but yes I'm worried about the future.

[sinhote]

Unfortunately not. I downgraded the plugin. Meanwhile I had a bunch of updates and my current version is

which is working fine. Since I need a running IDE without worries I do not update any more. Maybe in future I will give it another try.

Independent from this, Wild Web Developer uses that bundled typescript version instead of the version given in each project's package.json. As long as your projects do fine with this its OK, but especially maintaining older code is a problem. So, at the moment the setup and the projects I'm working on are matching fine, but yes I'm worried about the future.

Hey! Thanks! Sorry to ask too many questions, but how did you downgrade? I'm trying to find version 1.0.0 in the repos and I cannot find it. Just 1.3.0 and 1.4.0, which has the same problems.

Thanks in advance!

[stephanpelikan]

@sinhote : No problem. I removed WWW manually. To do so, got to Help->Install New Software->Already Installed search for "Wild" and remove it.

Afterwards I added this repo

https://download.eclipse.org/wildwebdeveloper/releases/1.0.0

at Help->Install New Software and installed all packages. That workes in November. Please make a backup of your Eclipse- and your workspace-folder before doing the patch. There is no guarantee that it will work with current plugins or with your plugins installed in particular.

[sinhote]

@stephanpelikan Thanks! It worked! I actually had to provide a manual solution because there were conflicts with the dependencies and other installed components. Fortunately, it all boiled down to an m2e dependency, and since I don't use Maven at all, I could simply uninstall it.

Thanks again for the help. I hope they can sort this issue out in the next releases.

[mickaelistria]

Thanks again for the help. I hope they can sort this issue out in the next releases.

If people who face the issue roll back to older versions instead of contributing to its resolution, then it's even less likely to be fixed.

[sinhote]

Thanks again for the help. I hope they can sort this issue out in the next releases.

If people who face the issue roll back to older versions instead of contributing to its resolution, then it's even less likely to be fixed.

I meant no disrespect here. I'm glad that this plugin exists and it's great we can use it for free, but I'd be more glad if it worked well when that can be fixed. I don't think I came here demanding that someone fixed it for me, I just came looking to find a workaround. This was not a complaint.

Not everybody has the time and not everybody who has the ability and knowledge to use a piece of software has the ability to improve it. I know this is obvious but I was not the one who started posting platitudes.

I wish I could support other projects, but I don't have the time and, frankly, I don't think I need to justify that to anybody that is so quick to draw conclusions.

Thanks for your work as a contributor but that does not give your the right to have that attitude.

Have a nice day.