Fix JS/TS Refactoring Rename JUnit Test #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
License check failure is due to eclipse-dash/dash-licenses#195 - not related to the PR |
vrubezhny
force-pushed
the
fixRefactoringRenameJUnitTest
branch
from
4d58931 to
0b16e45
Compare
Contributor
|
Can you please describe in commit message what makes that change is now necessary? |
vrubezhny
force-pushed
the
fixRefactoringRenameJUnitTest
branch
from
0b16e45 to
95cbc03
Compare
Due to change in `typescript-language-server@2.2.0` that implements `prepareRename` request now we have to implicitly set the new value for an identofier im `Refactoring->Rename` dialog during the test. See: [`feat: support textDocument/prepareRename request eclipse-wildwebdeveloper#628` change](typescript-language-server/typescript-language-server#628)
vrubezhny
force-pushed
the
fixRefactoringRenameJUnitTest
branch
from
95cbc03 to
2d28c9f
Compare
Contributor
Author
Updated: #1001 (comment) |
Contributor
Author
This PR should fix failing |
Contributor
|
Good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to change in
typescript-language-server@2.2.0that implementsprepareRenamerequest now we have to implicitly set the new value for an identofier imRefactoring->Renamedialog during the test.See:
feat: support textDocument/prepareRename request #628change