Skip to content

Conversation

@angelozerr
Copy link
Contributor

New XML format settings

Signed-off-by: azerr azerr@redhat.com

Here a screenshot will all missing settings coming from the new formatter:

image

Label should be revisisted because some label are too long (any review are welcome), but I did that quickly .

Signed-off-by: azerr <azerr@redhat.com>
@garretwilson
Copy link

Label should be revisisted because some label are too long (any review are welcome), but I did that quickly .

Just a tip; things like "The value represents the …" should not be part of the label. That is help text. A long time ago we would have mouse hovers over the label or over a question mark that would show the help text as a tooltip. I note also there is a (?) in the bottom, left-hand corner to bring up help, but I don't know if anybody really uses the help system nowadays.

At the least you should probably move this help text to a separate label. But most of these could use extra explanation, so you can't add extra labels for all of them.

Surely Eclipse in general has provided some policy for how plugins should provide help information in the preferences dialog? I would be willing to bet on it, as surely this is not the first time a plugin ever needed to provide help information for an option.

@angelozerr
Copy link
Contributor Author

@garretwilson I agree with you, label are not very good and it requires some fix. I did that very quickly to provide to the user the capability to customize the XML formatter, but I hope some other people will build a more exciting UI and improve the preferences with some help tooltip like you suggested, but to be honnest with you I have no time to do that (I did that in my spare time), so any contribution are welcome!

@garretwilson
Copy link

… I have no time to do that …

I completely understand. But then I suggest taking out the "help sentence" altogether. Users might find it irritating when they change to another entry in the preferences dialog and suddenly the dialog width doubles or triples (or shows scroll bars, which would be even more irritating).

@garretwilson
Copy link

"Join CDATAContent on format" has a typo: a missing space.

@mickaelistria
Copy link
Contributor

Let's merge it as it's good quality.
@garretwilson your suggestions for labels are more than welcome as further pull requests!

@mickaelistria mickaelistria merged commit 7c20109 into eclipse-wildwebdeveloper:master Dec 15, 2022
@angelozerr
Copy link
Contributor Author

"Join CDATAContent on format" has a typo: a missing space.

Please contribute by update any label at https://github.com/eclipse/wildwebdeveloper/blob/master/org.eclipse.wildwebdeveloper.xml/src/org/eclipse/wildwebdeveloper/xml/internal/ui/messages.properties#L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants