Bump rxjs from 7.6.0 to 7.8.0 in /org.eclipse.wildwebdeveloper.tests/testProjects/angular-app #1027

dependabot · 2022-12-23T11:53:18Z

Bumps rxjs from 7.6.0 to 7.8.0.

Changelog

7.8.0 (2022-12-15)

Features

buffer: closingNotifier now supports any ObservableInput (#7073) (61b877a)

delayWhen: delayWhen's delayDurationSelector now supports any ObservableInput (#7049) (dfd95db)

sequenceEqual: compareTo now supports any ObservableInput (#7102) (d501961)

share: ShareConfig factory properties now supports any ObservableInput (#7093) (cc3995a)

skipUntil: notifier now supports any ObservableInput (#7091) (60d6c40)

window: windowBoundaries now supports any ObservableInput (#7088) (8c4347c)

7.7.0 (2022-12-15)

Features

distinct: flush argument now supports any ObservableInput (#7081) (74c9ebd)

repeatWhen: notifier supports ObservableInput (#7103) (8f1b976)

retryWhen: notifier now supports any ObservableInput (#7105) (794f806)

sample: notifier now supports any ObservableInput (#7104) (b18c2eb)

Commits

0a4e8bf chore(publish): 7.8.0
cc3995a feat(share): ShareConfig factory properties should support ObservableInput (#...
dfd95db feat(delayWhen): delayWhen's delayDurationSelector should support `Observ...
61b877a feat(buffer): closingNotifier should support ObservableInput (#7073)
d501961 feat(sequenceEqual): compareTo should support ObservableInput (#7102)
60d6c40 feat(skipUntil): notifier should support ObservableInput (#7091)
8c4347c feat(window): windowBoundaries should support ObservableInput (#7088)
030b682 chore(publish): 7.7.0
794f806 feat(retryWhen): notifier now supports any ObservableInput (#7105)
b18c2eb feat(sample): notifier now supports any ObservableInput (#7104)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

vrubezhny · 2022-12-23T20:08:12Z

IP Team review request created: npm/npmjs/-/rxjs/7.8.0

mickaelistria · 2023-01-02T10:27:25Z

Build doesn't start

WARNING: Unable to create pod: kubernetes wildwebdeveloper/wildwebdeveloper-buildtest-pod-vs0tq-ttzrf because kubernetes resource quota exceeded. 
Failure executing: POST at: https://10.30.0.1/api/v1/namespaces/wildwebdeveloper/pods. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. pods "wildwebdeveloper-buildtest-pod-vs0tq-ttzrf" is forbidden: exceeded quota: jenkins-instance-quota, requested: limits.memory=6400Mi,requests.memory=6400Mi, used: limits.memory=7936Mi,requests.memory=7936Mi, limited: limits.memory=10Gi,requests.memory=10Gi.
Retrying...

@fgurr @mbarbero anything we're doing wrong on our side or should we open a helpdesk ticket to report it?

vrubezhny · 2023-01-03T14:18:52Z

@dependabot rebase

dependabot · 2023-01-03T14:18:54Z

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

vrubezhny · 2023-01-03T14:21:46Z

@dependabot recreate

Bumps [rxjs](https://github.com/reactivex/rxjs) from 7.6.0 to 7.8.0. - [Release notes](https://github.com/reactivex/rxjs/releases) - [Changelog](https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md) - [Commits](ReactiveX/rxjs@7.6.0...7.8.0) --- updated-dependencies: - dependency-name: rxjs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

mickaelistria · 2023-01-03T14:31:38Z

/request-license-review

github-actions · 2023-01-03T14:36:09Z

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse/wildwebdeveloper/actions/runs/3830329950

mickaelistria · 2023-01-03T14:44:53Z

@vrubezhny it looks like the request-license-review doesn't take into account the NPM report from dash analyzer. Was it working earlier or is it still something in progress?

vrubezhny · 2023-01-03T14:58:59Z

@mickaelistria It works as expected: When you manually request a review by posting a /request-license-review comment it builds successfully if all the required reviews are successfully created. In this case:

[main] INFO A review is required for npm/npmjs/-/ajv/8.12.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/6024 .

All the next tries to invoke this check (re-build License check / npm-check (pull_request) ) will fail until https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/6024 is resolved (and no new updates appear)

Once the reivew request is resolved and the results are published - the check will start resulting green again

The fact of review request creation doesn't makes a library/module approved immediately.

mickaelistria · 2023-01-03T15:04:20Z

Where do you see

[main] INFO A review is required for npm/npmjs/-/ajv/8.12.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/6024 .

?
I tried /request-license-review and it returned ✔ All licenses already successfully vetted. It's a bit confusing...

vrubezhny · 2023-01-03T15:11:34Z

It can be seen in Actions -> Bump rxjs from 7.6.0 to 7.8.0 in /org.eclipse.wildwebdeveloper.tests/testProjects/angular-app : https://github.com/eclipse/wildwebdeveloper/actions/runs/3830329950/jobs/6518054274
You need to search the Job marked as: License check #751: Issue comment $1027 created by [mickaelistria] - this is the Job started after your /request-license-review comment

vrubezhny · 2023-01-03T15:14:55Z

I tried /request-license-review and it returned ✔ All licenses already successfully vetted. It's a bit confusing...

Yes. It's really confusing. But I don't know a way to finish the script using some kind of 'WARNING`-like status to indicate that request is created successfully, but the Licenses are not vetted yet

mickaelistria · 2023-01-03T17:01:52Z

It can be seen in ...

OK, thanks a lot!

Yes. It's really confusing. But I don't know a way to finish the script using some kind of 'WARNING`-like status to indicate that request is created successfully, but the Licenses are not vetted yet

I think it's the common dash action eclipse/dash-licenses/.github/workflows/mavenLicenseCheck.yml@master which logs this message about the Maven bits. I imagine we can try something like needs to wait for the result of the various step and create a generic mesage.

mickaelistria · 2023-01-03T17:13:47Z

/request-license-review

vrubezhny · 2023-01-03T17:19:12Z

Thanks for that link - I'll take a look on how does it work.

But, still, currently, npm-check works almost independently of call-mvn-license-check (at least their results do not interfere. (The only thing that works for npm-check that is actually placed into call-mvn-license-check is bot's reactions on rebasing/review-request-comment stuff... not more. Actually, npm-check (in terms of /request-license-review comment works exactly as call-license-check - at least I tried to make it similar how it is returning the exit status codes and messages.

So, I expect that, if we'll use something like needs, we'll get the same successful result code returned for /request-license-review action

vrubezhny · 2023-01-03T17:23:47Z

There is some mess happening with GitLab... Bot has already created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/6024 for npm/npmjs/-/ajv/8.12.0 and it's already resolved as approved.

But still Dash License Tool reports it as not approved. Also it allows to create duplication issues: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/6025 for the same module and version.

So, actually we can merge (as https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/6024 is approved), but npm-check will still be failing for some time.

github-actions · 2023-01-03T17:25:16Z

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse/wildwebdeveloper/actions/runs/3831523979

dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 23, 2022

mickaelistria force-pushed the dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper.tests/testProjects/angular-app/rxjs-7.8.0 branch 2 times, most recently from f232155 to f00601c Compare January 3, 2023 13:31

dependabot bot force-pushed the dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper.tests/testProjects/angular-app/rxjs-7.8.0 branch from f00601c to 1a7f71b Compare January 3, 2023 14:22

vrubezhny merged commit ee8626f into master Jan 3, 2023

dependabot bot deleted the dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper.tests/testProjects/angular-app/rxjs-7.8.0 branch January 3, 2023 19:31

Bump rxjs from 7.6.0 to 7.8.0 in /org.eclipse.wildwebdeveloper.tests/testProjects/angular-app #1027

Bump rxjs from 7.6.0 to 7.8.0 in /org.eclipse.wildwebdeveloper.tests/testProjects/angular-app #1027

Uh oh!

Conversation

dependabot bot commented on behalf of github Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

7.8.0 (2022-12-15)

Features

7.7.0 (2022-12-15)

Features

Uh oh!

vrubezhny commented Dec 23, 2022

Uh oh!

mickaelistria commented Jan 2, 2023

Uh oh!

vrubezhny commented Jan 3, 2023

Uh oh!

dependabot bot commented on behalf of github Jan 3, 2023

Uh oh!

vrubezhny commented Jan 3, 2023

Uh oh!

mickaelistria commented Jan 3, 2023

Uh oh!

github-actions bot commented Jan 3, 2023

Uh oh!

mickaelistria commented Jan 3, 2023

Uh oh!

vrubezhny commented Jan 3, 2023

Uh oh!

mickaelistria commented Jan 3, 2023

Uh oh!

vrubezhny commented Jan 3, 2023

Uh oh!

vrubezhny commented Jan 3, 2023

Uh oh!

mickaelistria commented Jan 3, 2023

Uh oh!

mickaelistria commented Jan 3, 2023

Uh oh!

vrubezhny commented Jan 3, 2023

Uh oh!

vrubezhny commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dependabot bot commented on behalf of github Dec 23, 2022 •

edited

Loading

vrubezhny commented Jan 3, 2023 •

edited

Loading