Skip to content

Conversation

@vrubezhny
Copy link
Contributor

No description provided.

@vrubezhny vrubezhny marked this pull request as draft June 2, 2023 18:18
@vrubezhny vrubezhny force-pushed the fixLsp4eApiBreaks branch 2 times, most recently from c18136d to 5eb8d47 Compare June 2, 2023 20:15
@vrubezhny vrubezhny marked this pull request as ready for review June 2, 2023 20:16
@vrubezhny vrubezhny force-pushed the fixLsp4eApiBreaks branch 6 times, most recently from a39f639 to 898b151 Compare June 3, 2023 21:07
@vrubezhny vrubezhny force-pushed the fixLsp4eApiBreaks branch from 898b151 to eaae1da Compare June 3, 2023 21:41
Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks very good. Anything particular you'd like me to give more attention? If not, the sooner we merge, the better.

@vrubezhny
Copy link
Contributor Author

This change looks very good. Anything particular you'd like me to give more attention? If not, the sooner we merge, the better.

@mickaelistria JUnit test TestTypeScript.testHTMLinTSXFile() is quite unstable failing by time out expired while trying to collect language servers for document. From one side - it's only a test that just started an editor, so the LS needs some time to initialize, so I've used 500ms timeout here, but we have a similar code collecting the LSs in AssociateGrammarHandler.executeServerCommand - I've put 100ms timeout here - in theory at least one LS is to be initialized and active at this point, but I still in doubt on what should be the correct timeout value here?

@mickaelistria
Copy link
Contributor

This test is working on the Jenkins build for this PR, so I woudn't worry about it. If it is the only concern, then I believe this PR is good to merge now.

@vrubezhny
Copy link
Contributor Author

Well. Just well be watching for UnsupportedOperationException("No language server has registered to handle command XXX")-like exceptions then.

@vrubezhny vrubezhny merged commit 2bbaa93 into eclipse-wildwebdeveloper:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants