Skip to content

Conversation

@zulus
Copy link
Contributor

@zulus zulus commented Sep 24, 2023

Low priority for all WWD content-types

@mickaelistria
Copy link
Contributor

Why a lower priority?

@zulus
Copy link
Contributor Author

zulus commented Sep 24, 2023

WTP SSE based editors (CSS, XML, HTML and PHP), require special IDocument implementation (IStructuredDocument), build via deprecated "org.eclipse.core.filebuffers.documentCreation" which is based on contentType.

Without this all SSE editors stops working after WWD installation. As an alternative WTP can set his content type priority as high, or finally replace IDocumentFactory by for example ForwardingDocumentProvider ;)

@mickaelistria
Copy link
Contributor

Would it be possible to fix the org.eclipse.core.filebuffers.documentCreation so it takes into account all content-types and matches the first one that has an association instead of just looking at the first content-type?

@zulus
Copy link
Contributor Author

zulus commented Sep 25, 2023

This ex point is deprecated, I'm afraid none care ;)

Maybe on WTP side, someone will be able to just write IDocumentProvider designed for StructuredSourceEditor and stop using this ex point

@zulus
Copy link
Contributor Author

zulus commented Sep 27, 2023

/request-license-review

Low priority for all WWD content-types
Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a harmful change anyway, so feel free to merge as soon as CI is happy with it.

@mickaelistria mickaelistria merged commit 61c0876 into eclipse-wildwebdeveloper:master Sep 27, 2023
@StefanLindner
Copy link

Now everything works fine. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants