Skip to content

Fix github workflows #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickaelistria merged 1 commit into from
Sep 25, 2023
Merged

Fix github workflows #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/MacOsPR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ jobs:
maven-version: 3.9.2
- uses: actions/setup-node@v3
with:
node-version: '20'
node-version: '18'
- name: Build with Maven
run: mvn -B clean verify
2 changes: 1 addition & 1 deletion .github/workflows/windowsPR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ jobs:
maven-version: 3.9.2
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'
Copy link
Contributor Author

@zulus zulus Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure we use same version as in embedder

- name: Build with Maven
run: mvn -B clean verify
1 change: 1 addition & 0 deletions org.eclipse.wildwebdeveloper/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"yaml-language-server": "1.14.0",
"vscode-languageserver-protocol": "3.17.4-next.3",
"vscode-languageserver-types": "3.17.4-next.2",
"vscode-languageserver": "8.1.0",
"vscode-css-languageserver": "file:target/vscode-css-languageserver-1.0.0.tgz",
Copy link
Contributor Author

@zulus zulus Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this vscode-languageserver is in root so nested node_modules is not required

Copy link
Contributor Author

@zulus zulus Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downgraded to 8.2 (9.0 have just 5 days)

"vscode-html-languageserver": "file:target/vscode-html-languageserver-1.0.0.tgz",
"vscode-json-languageserver": "file:target/vscode-json-languageserver-1.3.4.tgz",
Expand Down
15 changes: 15 additions & 0 deletions org.eclipse.wildwebdeveloper/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,19 @@
</target>
</configuration>
</execution>
<execution>
<id>remove package-lock before install</id>
<phase>compile</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<target>
<delete
file="${project.directory}/package-lock.json" />
</target>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
Expand Down Expand Up @@ -204,6 +217,8 @@
<arg>--only=prod</arg>
<arg>--no-bin-links</arg>
<arg>--ignore-scripts</arg>
<arg>--install-strategy=hoisted</arg>
<arg>--force</arg>
Copy link
Contributor Author

@zulus zulus Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure dependencies are always fresh, without this tests fail on github but pass jenkins

Copy link
Contributor Author

@zulus zulus Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force also will ignore platform requirements, so will be possible to add fsevents for mac users ;)

<!-- The actual verions for the LS and other dependency NPM Modules are to be set in './package.json file',
which is used to install the dependencies -->
</arguments>
Expand Down