fix: misspelled "#property-values" include #1429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If I'm not mistaken, this file is directly copied from VSCode. Can you please check whether the issue is present in VSCode file too? |
Member
Author
|
The issue is not present in upstream anymore. The CSS file is actually outdated and there is another draft PR #1246 to update all grammar files but it is stalled for already six months. The change of my PR however is trivial and safe/quick to merge whereas #1246 probably needs more work/time (IP review etc). |
Contributor
|
There is no longer css grammar anymore with 796ae27 . The one from tm4e is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file does not define a
property-valuebut not aproperty-valuesrule - which is correctly referenced in all other include directives.