Skip to content

YAML preferences #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vrubezhny merged 1 commit into from
Nov 1, 2022
Merged

YAML preferences #930

vrubezhny merged 1 commit into from
Nov 1, 2022

Conversation

@angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Oct 31, 2022 •
edited
Loading

YAML preferences

image

Signed-off-by: azerr azerr@redhat.com

This PR provides all settings which manages YAML LS. I set to draft because I need to test if it works correctly, but you can try it.

@vrubezhny
Copy link
Contributor

vrubezhny commented Oct 31, 2022

@angelozerr Also, please, take a look at YAML JUnit tests - they fail probably because of changes in editor configuration:

Failures: 
  TestYaml.testSchemaExtensionPoint:91->testErrorFile:85 expected: <true> but was: <false>
  TestYaml.testSchemaExtensionPointUsingPlatformURL:96->testErrorFile:85 expected: <true> but was: <false>

This was referenced Oct 31, 2022
Open
Open
@angelozerr angelozerr marked this pull request as ready for review October 31, 2022 18:55
vrubezhny
vrubezhny requested changes Nov 1, 2022
View reviewed changes
@angelozerr angelozerr force-pushed the yaml-preferences branch 2 times, most recently from c4ac695 to 4f6e71c Compare November 1, 2022 00:35
@angelozerr
Copy link
Contributor Author

angelozerr commented Nov 1, 2022

Please note the YAML configuration must be improve to collect http and others ections.See https://github.com/eclipse/wildwebdeveloper/pull/930/files#diff-35f0eb9d34c1bd751f939c11d145d2dc8d81295432566dc74b5f882f2beb5d0cR42

@angelozerr
YAML preferences
d5ccde2 
Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this pull request Nov 1, 2022
Closed
@vrubezhny vrubezhny merged commit f002ea8 into eclipse-wildwebdeveloper:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrubezhny vrubezhny vrubezhny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angelozerr @vrubezhny