Associate grammar file with CodeLens #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
xml_associate_grammar
branch
2 times, most recently
from
cb772cd to
3af424f
Compare
Contributor
Author
|
CI Build failed, but I don't understand, please help me. |
Contributor
|
First, please ignore the windowsPR build, it suffers from a bug that makes it not reliable. Then, please don't change bundle version of bundles that are not modified by your patch. |
angelozerr
force-pushed
the
xml_associate_grammar
branch
from
3af424f to
a01a6a8
Compare
Contributor
Author
Thanks for the info.
I pushed a new commit, hope it will good. |
angelozerr
force-pushed
the
xml_associate_grammar
branch
from
a01a6a8 to
1487660
Compare
vrubezhny
reviewed
Nov 9, 2022
| <groupId>org.eclipse.wildwebdeveloper</groupId> | ||
| <artifactId>parent</artifactId> | ||
| <version>1.0.0-SNAPSHOT</version> | ||
| <version>1.0.1-SNAPSHOT</version> |
Contributor
There was a problem hiding this comment.
Please, roll it back to be <version>1.0.0-SNAPSHOT</version> - we haven't change parent version yet
Contributor
Author
There was a problem hiding this comment.
Good catch. fixed
angelozerr
force-pushed
the
xml_associate_grammar
branch
from
1487660 to
0e801a8
Compare
vrubezhny
reviewed
Nov 9, 2022
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Could you, please:
- rebase against latest master
- bump org.eclipse.wildwebdeveloper.feature to be 1.0.1-SNAPSHOT
and forcibly push these changes
Thanks
angelozerr
force-pushed
the
xml_associate_grammar
branch
from
0e801a8 to
6199c07
Compare
vrubezhny
added a commit
to vrubezhny/wildwebdeveloper
that referenced
this pull request
Dec 15, 2022
Remove the unused messages left after merge of eclipse-wildwebdeveloper#944 and eclipse-wildwebdeveloper#933 (eclipse-wildwebdeveloper@fdc1154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the capability to associate an XML file with a XSD, DTD, RelaxNG grammar file easily by clicking on the CodeLens. See the following demo: