Pass languageid to ESLint language server #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
eslint-comments
branch
from
63f6ac0 to
3c5a575
Compare
angelozerr
reviewed
Nov 15, 2022
| contentType="org.eclipse.wildwebdeveloper.jsx" | ||
| id="org.eclipse.wildwebdeveloper.eslint" | ||
| languageId="javascriptreact"/> | ||
| <contentTypeMapping |
Contributor
There was a problem hiding this comment.
It is important that you keep javascript as langage id because otherwise inlay hint préférences will not work.
Indeed typescript langage server uses this langage id to apply proper preferences
Contributor
Author
There was a problem hiding this comment.
That's not how the eslint langauge server works.
Contributor
There was a problem hiding this comment.
Thats annoying. We will l'oose i.lay hint préférences for jsx and tsx
angelozerr
reviewed
Nov 15, 2022
| contentType="org.eclipse.wildwebdeveloper.tsx" | ||
| id="org.eclipse.wildwebdeveloper.eslint" | ||
| languageId="typescriptreact"/> | ||
| <contentTypeMapping |
Contributor
There was a problem hiding this comment.
Please keep typescript as langage id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #956 and #957