Allow tsconfig.json to have trailing commas #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
requested changes
Dec 4, 2022
Comment on lines
323
to
326
| var responseString = response.toString(); | ||
| responseString = BlockCommentPattern.matcher(responseString).replaceAll(""); | ||
| responseString = LineCommentPattern.matcher(responseString).replaceAll(""); | ||
| responseString = TrailingCommaPattern.matcher(responseString).replaceAll("$1}"); |
Contributor
There was a problem hiding this comment.
Can you please extract it into a dedicated method with a nice name and some documentation to not forget what case they're serving?
Member
Author
There was a problem hiding this comment.
Done by acdd258. The docstring doesn't make explicit mention of what kind of preprocessing is done, so that if any other JSON tweaks are needed, the documentation & method name may remain unchanged & continue to be accurate.
Contributor
|
Thanks. It looks like there is some ECA check issue. Can you please verify you used on both commits the author email that matches the one you signed ECA with? |
AndrewFerr
force-pushed
the
tsconfig-trailing-commas
branch
from
acdd258 to
889b5dc
Compare
Member
Author
|
I've amended the commits' author/committer email address to the one I signed the ECA with. |
mickaelistria
force-pushed
the
tsconfig-trailing-commas
branch
from
889b5dc to
844bb54
Compare
Contributor
|
The failure is definitely not related. let's merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #971
Note that I did look into replacing Gson with another parser (I gave Jackson a try), but it turns out that Gson is used not only in WWD, but across the LSP4E and TM4E projects, which all pass Gson objects between each other. Replacing Gson would thus take a bit of coordination across all three projects.
Plus, the libraries of whatever new parser is used would have to be provided in WWD's Eclipse repository, as Gson currently is.
So for now, just doing some manual parsing should be the least disruptive solution for the filed issue.
Also note that the comment-stripping isn't strictly necessary (as Gson's default configuration accepts comments), but it helps with handling comments that follow a trailing comma.