Skip to content

Fix compatibility issue with Windows#1680

Merged
sdirix merged 10 commits into
eclipsesource:masterfrom
TheZoker:fix-windows
Apr 30, 2021
Merged

Fix compatibility issue with Windows#1680
sdirix merged 10 commits into
eclipsesource:masterfrom
TheZoker:fix-windows

Conversation

@TheZoker
Copy link
Copy Markdown
Contributor

@TheZoker TheZoker commented Jan 20, 2021

Fix #752

  • Add devDependencies to single packages and remove bin paths
  • Update typedoc to be compatible with windows
  • Use cp-cli instead cp for windows compatibility

Status/Tested:

  • npm run ci ✔️
  • npm run install ✔️
  • npm run init ✔️
  • npm run build ✔️
  • npm run test ✖️ (error only within the angular-material package)
  • npm run serve ✔️ (within the vue package)
  • npm run dev ✔️ (within the material, vanilla package)

npm run test error:

npm run test

> @jsonforms/angular-material@2.5.0 test jsonforms\packages\angular-material
> karma start ./test-config/karma.conf.js --single-run
(node:5604) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(Use `node --trace-deprecation ...` to show where the warning was created)
‼ 「wdm」:
i 「wdm」: Compiled with warnings.
i 「wdm」: Compiling...
‼ 「wdm」:
i 「wdm」: Compiled with warnings.
27 01 2021 14:36:32.327:INFO [karma-server]: Karma v3.1.4 server started at http://0.0.0.0:9876/
27 01 2021 14:36:32.327:INFO [launcher]: Launching browsers ChromeHeadlessNoSandbox with concurrency unlimited
27 01 2021 14:36:32.343:INFO [launcher]: Starting browser ChromeHeadless
27 01 2021 14:37:32.360:WARN [launcher]: ChromeHeadless have not captured in 60000 ms, killing.
27 01 2021 14:37:34.376:WARN [launcher]: ChromeHeadless was not killed in 2000 ms, sending SIGKILL.
27 01 2021 14:37:36.392:WARN [launcher]: ChromeHeadless was not killed by SIGKILL in 2000 ms, continuing.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @jsonforms/angular-material@2.5.0 test: `karma start ./test-config/karma.conf.js --single-run`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @jsonforms/angular-material@2.5.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@TheZoker TheZoker force-pushed the fix-windows branch 3 times, most recently from 3b5a7bf to 89411aa Compare January 27, 2021 15:00
@sdirix
Copy link
Copy Markdown
Member

sdirix commented Mar 10, 2021

@TheZoker Can you rebase on latest master? I merged some new bundles which also need to be migrated and edited some existing ones, so you might have conflicts.

@sdirix sdirix marked this pull request as ready for review April 30, 2021 16:30
@sdirix sdirix force-pushed the fix-windows branch 3 times, most recently from aac69b2 to 3be3cc7 Compare April 30, 2021 19:28
@sdirix sdirix merged commit 8f14b23 into eclipsesource:master Apr 30, 2021
@TheZoker TheZoker deleted the fix-windows branch April 30, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run build doesn't work on Windows because ../ (forward slash) is not recognized

2 participants