Skip to content

Fix incorrect data retrieval is special cases#270

Open
Ozaq wants to merge 1 commit intodevelopfrom
fix/FDB-620
Open

Fix incorrect data retrieval is special cases#270
Ozaq wants to merge 1 commit intodevelopfrom
fix/FDB-620

Conversation

@Ozaq
Copy link
Copy Markdown
Member

@Ozaq Ozaq commented Apr 23, 2026

Description

Now correctly retrieves data if non-chunked extension axis is defined.

Fixes: FDB 620

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/fdb/pull-requests/PR-270

@Ozaq Ozaq requested a review from tbkr April 23, 2026 18:31
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 85.50725% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.96%. Comparing base (54f51c4) to head (fa2655b).

Files with missing lines Patch % Lines
src/chunked_data_view/GribExtractor.cc 0.00% 21 Missing ⚠️
tests/chunked_data_view/test_builder.cc 0.00% 5 Missing ⚠️
tests/chunked_data_view/test_view.cc 96.77% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #270      +/-   ##
===========================================
+ Coverage    70.84%   70.96%   +0.11%     
===========================================
  Files          372      372              
  Lines        23309    23465     +156     
  Branches      2454     2458       +4     
===========================================
+ Hits         16514    16652     +138     
- Misses        6795     6813      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Now correctly retrieves data if non-chunked extension axis is defined.

Fixes: FDB 620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants