Skip to content

fix: remove try from tests#271

Open
mcakircali wants to merge 1 commit intodevelopfrom
fix/tests-remove-try
Open

fix: remove try from tests#271
mcakircali wants to merge 1 commit intodevelopfrom
fix/tests-remove-try

Conversation

@mcakircali
Copy link
Copy Markdown
Contributor

@mcakircali mcakircali commented Apr 28, 2026

Description

removes try() from shell tests as it creates sub-shell and returns true. one could add pipefail but it's prone to error. so, simply removed those and add -eux (e: exit, u:unset, x:print)

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/fdb/pull-requests/PR-271

@mcakircali mcakircali requested a review from simondsmart April 28, 2026 12:44
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.86%. Comparing base (7c39511) to head (0c76e70).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
+ Coverage    70.72%   70.86%   +0.13%     
===========================================
  Files          372      372              
  Lines        23309    23309              
  Branches      2455     2454       -1     
===========================================
+ Hits         16486    16517      +31     
+ Misses        6823     6792      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants