Merged
Conversation
ChrisspyB
force-pushed
the
feature/FDB-393-wipe
branch
2 times, most recently
from
851e132 to
eac6322
Compare
Member
Author
|
NB: CI won't pass until the corresponding FDB PR is merged. |
ChrisspyB
force-pushed
the
feature/FDB-393-wipe
branch
from
eac6322 to
17a8146
Compare
Collaborator
|
Had a conversation with @ChrisspyB, the PR looks nice. The remarks regarding the API differences to the C, C++ API are valid and should be addressed if not intended. If the FDB part is merged, we can merge this as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #48 +/- ##
===========================================
+ Coverage 97.20% 97.63% +0.43%
===========================================
Files 7 8 +1
Lines 322 381 +59
===========================================
+ Hits 313 372 +59
Misses 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisspyB
force-pushed
the
feature/FDB-393-wipe
branch
from
17a8146 to
7431abf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: ecmwf/fdb#114
Adds wipe and purge to the python API, and some simple tests.