fix(BoundingRect): don't check if the width and height is finite in constructor.#748
Merged
Conversation
5 tasks
pissang
approved these changes
Apr 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix apache/echarts#14534
PENDING:
It seems
Infinitycannot be simply considered as0, after all, it's infinitely large but not zero.And I saw the
BoundingRect#unionis checking if the value is finite, which indicates the infinite values can exist in the constructed instance ofBoundingRect, so I'm thinking the no check need to do in the constructor.