[feature] Enhancement of split / combine morphing.#775
Merged
Conversation
remove getParentTransform because it's conflict with getComputedTransform
pissang
changed the title
pissang
changed the title
It happens when duration is set 0
6 tasks
100pah
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes
This pull request did some optimizations on split / combine morphing.
Rename some of the APIs to avoid conflicts.
combine=>combineMorphseparate=>separateMorphThe parameters and return type are similar.
Can divide arbitrary path now. Not only sector and rectangles.
For simple paths like sector and rectangle. It will divide shape evenly on each dimension. For other complex unknown shape paths. It will convert the path to a polygon. Then divide the polygon with a grid.
Additionally,
combineMorphandseparateMorphalso provide an option that can override the default dividing algorithm.Some bug fixes.
Some other changes: