fix(canvas): fix unexpected none or null value for ctx.strokeStyle & ctx.fillStyle#784
Merged
Conversation
…e & ctx.fillStyle, resolves apache/echarts#15238.
pissang
requested changes
Jul 12, 2021
…eStyle/fillStyle.
pissang
approved these changes
Jul 15, 2021
Collaborator
Author
|
I just want to say we can remove the null check. |
Contributor
|
@plainheart We can improve it in another PR😅 |
pissang
added a commit
that referenced
this pull request
Jul 15, 2021
tweak #784, remove unnecessary null check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve apache/echarts#15238.
Because unexpected value
nullor'none'is assigned toctx.strokeStyleorctx.fillStyle, the Firefox devtools will print lots of annoying CSS warnings.