Expanded UNICODE range for Latin characters from 33-255 to 33-383 #849
Merged
Conversation
…k 'Latin Extended-A' - European characters)
Contributor
|
Wow thanks for filling the gap! Sorry we didn't notice that! |
pissang
approved these changes
Nov 19, 2021
Author
|
Thank you for the quick reply. Keep up a good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm doing a small project and noticed that in TextStyleProps we have
overflow?: 'break' | 'breakAll' | 'truncate' | 'none'. The 'break' should break by word and it is, but not in all cases.There is a list of unicode characters divided into blocks (https://en.wikipedia.org/wiki/List_of_Unicode_characters) and zrender only considers Latin characters in the range from 33 to 255 which is 1st and 2nd block. Many European characters are in the 3rd block (Latin Extended-A https://en.wikipedia.org/wiki/Latin_Extended-A).
Adding the 3rd UNICODE block should not cause any trouble (there are no characters that can be considered 'special') and would help a lot in using European languages because now some words are breaking in half :(