fix(sector): fix a case in which the angle is NaN.#880
Merged
Conversation
Collaborator
Author
|
BTW, I found another bug related to label & labelLine. It should be related to these three places.
It didn't take into account the case in which the data becomes normal from NaN value. Here is an online test case: https://codepen.io/plainheart/pen/ZEXNQVy |
Contributor
|
I think shape with NaN value should be not displayed. If we treat it same with 0. Border will still be drawn. |
Collaborator
Author
|
@pissang You're right. Fixed. |
pissang
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #870, we fixed the animation bug caused by the
NaNvalue. But that only works in canvas renderer. In SVG renderer, the path can't be successfully built because of theNaNvalue.The related test case is the same as #870, that is, the last test case in echarts/test/pie-animation.html