Skip to content

fix(sector): fix a case in which the angle is NaN.#880

Merged
pissang merged 2 commits into
releasefrom
fix-sector
Jan 19, 2022
Merged

fix(sector): fix a case in which the angle is NaN.#880
pissang merged 2 commits into
releasefrom
fix-sector

Conversation

@plainheart
Copy link
Copy Markdown
Collaborator

In #870, we fixed the animation bug caused by the NaN value. But that only works in canvas renderer. In SVG renderer, the path can't be successfully built because of the NaN value.

The related test case is the same as #870, that is, the last test case in echarts/test/pie-animation.html

@plainheart
Copy link
Copy Markdown
Collaborator Author

plainheart commented Jan 19, 2022

@plainheart plainheart requested a review from pissang January 19, 2022 13:14
@pissang
Copy link
Copy Markdown
Contributor

pissang commented Jan 19, 2022

I think shape with NaN value should be not displayed. If we treat it same with 0. Border will still be drawn.

@plainheart
Copy link
Copy Markdown
Collaborator Author

@pissang You're right. Fixed.

@pissang pissang merged commit 123aa27 into release Jan 19, 2022
@pissang pissang deleted the fix-sector branch January 19, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants