Merged
Conversation
ignore metastore/warehouse files
lsulak-eco
reviewed
Nov 25, 2020
databricks_test/__init__.py
Outdated
| * the symbol `>` indicates that the row was found in the *actual* table but not in the *expected* table | ||
| * the symbol `=` indicates that the row was matched between the *expected* and *actual* tables | ||
|
|
||
| (this behaviour inspired by the `tSQLt` unit test framework for SQL Server) |
There was a problem hiding this comment.
Should this text be here? I can see it in README.md
lsulak-eco
reviewed
Nov 25, 2020
| .appName("test-pyspark") | ||
| #add delta lake support | ||
| .config("spark.jars.packages", "io.delta:delta-core_2.12:0.7.0") | ||
| .config("spark.sql.extensions", "io.delta.sql.DeltaSparkSessionExtension") |
lsulak-eco
reviewed
Nov 25, 2020
| x, "") | ||
|
|
||
| # Run notebook | ||
| dbrickstest.run_notebook(".", "deltalake_write_notebook") |
There was a problem hiding this comment.
there is no check whether the data points ( spark.range(0, 5) ) were actually written and are correct
| # Instrument for unit tests. This is only executed in local unit tests, not in Databricks. | ||
| if 'dbutils' not in locals(): | ||
| import databricks_test | ||
| databricks_test.inject_variables() |
There was a problem hiding this comment.
yes, I remember now, so we'll need to do this in every notebook under test. I don't understand why the framework was written in this way, there must be a nicer way...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.