Add %F output format option to print timestamps in a human-readable format #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
reviewed
Jan 19, 2022
Owner
edenhill
left a comment
edenhill
left a comment
There was a problem hiding this comment.
Great stuff! Left some minor comments.
alexey-sveshnikov
force-pushed
the
human-readable-timestamps
branch
from
863e023 to
e640afd
Compare
alexey-sveshnikov
force-pushed
the
human-readable-timestamps
branch
from
e640afd to
39b459a
Compare
edenhill
requested changes
Feb 24, 2022
| char buf[80]; | ||
| format_timestamp(buf, | ||
| sizeof(buf), | ||
| rd_kafka_message_timestamp(rkmessage, |
Owner
There was a problem hiding this comment.
I think we need to check that tstype is valid, on older brokers (or message format versions) the tstype will be NONE and the timestamp unusable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Magnus!
I added %F format option to display timestamps in human-readable format.
I suggest a format that is compatible with both ISO8601 and RFC3399:
2021-11-01T23:04:35.113+0300.Closes #189. Some code is borrowed from #216.
UPD: I see the failed CI job, going to check it later