Conversation
bittner
force-pushed
the
feature/add-pdk-to-idesdk
branch
from
c845421 to
a1f8661
Compare
|
🔔 ping! This still seem valid even though Puppet Labs state on the download page that the PDK is "available via native package managers". Seems a bit tricky though picking the right Puppet version for the repository-based installation. |
| provider => 'dpkg', | ||
| } | ||
|
|
||
| file { '/tmp/pdk.deb': |
There was a problem hiding this comment.
I don't think we need to download the package for linux any longer.
If you are running puppet on a machine there is a good chance you installed it from the official repos, which also have pdk now. I think we can just get away with the package.
There was a problem hiding this comment.
Maybe yes. For a pure PDK installation it's still more than just package {'pdk':}, though, unfortunately. That's still my motivation. You can look at my Ansible-driven implementation for comparison. It's 3 steps that you won't recall from the top of your head. They make sense to automate.
There was a problem hiding this comment.
Can it be optional to download the package? I will use this and I can make the assumption that the puppet repo is setup on my machines. Can you use a param and do either?
bittner
force-pushed
the
feature/add-pdk-to-idesdk
branch
from
a1f8661 to
ff3bd57
Compare
bittner
force-pushed
the
feature/add-pdk-to-idesdk
branch
from
fefb875 to
0332319
Compare
|
|
||
| class software::idesdk::pdk ( | ||
| $ensure = $software::params::software_ensure, | ||
| $version = $software::params::pdk_version, |
| $url = $software::params::pdk_url, | ||
| ) inherits software::params { | ||
|
|
||
| validate_string($ensure) |
There was a problem hiding this comment.
Can we get rid of the legacy validate. I think I have just been removing this one from the other profiles.
|
resolved by 1edd867 |
2 participants
These changes add PDK, the Puppet Development Kit, to the idesdk section. This is meant to live in this repo as long as Puppetlab's packages are not yet installable off repository servers (using the Puppet
packageresource).Fixes #14.