Skip to content

Add source of auth#1

Open
thcrock wants to merge 1 commit intomasterfrom
addAuthSource
Open

Add source of auth#1
thcrock wants to merge 1 commit intomasterfrom
addAuthSource

Conversation

@thcrock
Copy link
Copy Markdown
Contributor

@thcrock thcrock commented Mar 4, 2015

We want to record the referral source of the authorized users we get (email, Facebook, etc). That'll be something to add later, but for now I wanted a convenient place to put it for the Reports page.

@jesteria
Copy link
Copy Markdown

jesteria commented Mar 4, 2015

So this is something that we might ... put in an incoming auth URL's query string?

Comment thread magnus/models.py
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty_name might be a bit verbose; (I hope it's pretty, but at least it'll be a name).

Of course, slug is fine, especially if we might be putting these in URLs. (code, et al, work too.) Regardless, you might want to enforce sluginess with a SlugField.

@thcrock
Copy link
Copy Markdown
Contributor Author

thcrock commented Mar 4, 2015

Sure. We may keep more detailed information in the query string, but when we create a ClientAppUser record we decide on a bucket, represented by the FBAuthSource.

@jesteria
Copy link
Copy Markdown

jesteria commented Mar 4, 2015

I'm not sure I understand "we may keep more detailed information in the query string", but yeah, I'm just asking how we might decide on the bucket – from some information stored on the campaign? from an auth query string param?

@thcrock
Copy link
Copy Markdown
Contributor Author

thcrock commented Mar 4, 2015

Either the URL or a campaign could work. I think the flexibility afforded by encoding in the URL would be preferable to creating different campaigns for different sources, if making it work doesn't end up being too tough.

@jesteria
Copy link
Copy Markdown

jesteria commented Mar 5, 2015

Sure. Also, in case there's as much overlap as I imagine there is, we have the idea of Visit.source already, which is passed around in the query string as efsrc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants