Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

deps: vendor node-maintenance-operator api#1172

Merged
malt3 merged 4 commits intomainfrom
feat/nmo-api-vendor
Feb 14, 2023
Merged

deps: vendor node-maintenance-operator api#1172
malt3 merged 4 commits intomainfrom
feat/nmo-api-vendor

Conversation

@malt3
Copy link
Copy Markdown
Contributor

@malt3 malt3 commented Feb 13, 2023

Proposed change(s)

  • Vendor node-maintenance-operator api folder

Additional info

Checklist

  • Add labels (e.g., for changelog category)

@malt3 malt3 added dependencies Pull requests that update a dependency file no changelog Change won't be listed in release changelog labels Feb 13, 2023
@malt3 malt3 requested a review from katexochen as a code owner February 13, 2023 07:34
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 13, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit fca9e6b
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63ebc4830da264000887581f

@malt3 malt3 force-pushed the feat/nmo-api-vendor branch 5 times, most recently from 542aab7 to 7e064d1 Compare February 13, 2023 07:45
@malt3
Copy link
Copy Markdown
Contributor Author

malt3 commented Feb 13, 2023

@thomasten can you look at the vendored code license? Also: Ideas on how we can handle the license check? (Maybe we can ignore the 3rdparty folder?)
80785fc

@thomasten
Copy link
Copy Markdown
Member

I believe doing it like this is sufficient to comply with the license. At least if you haven't modified any of the copied files.
Ignoring the 3rdparty folder in the license header check seems the right solution to me.

@malt3 malt3 changed the title nmo api vendor deps: vendor node-maintenance-operator api Feb 13, 2023
@malt3 malt3 force-pushed the feat/nmo-api-vendor branch from 800e885 to 4387f3e Compare February 14, 2023 16:30
Comment thread 3rdparty/node-maintenance-operator/api/v1beta1/download.sh Outdated
Comment thread 3rdparty/node-maintenance-operator/go.mod Outdated
@malt3 malt3 force-pushed the feat/nmo-api-vendor branch 2 times, most recently from 5930eaf to 70cbb4a Compare February 14, 2023 17:14
@malt3 malt3 force-pushed the feat/nmo-api-vendor branch from 70cbb4a to 0cb0466 Compare February 14, 2023 17:18
@malt3 malt3 force-pushed the feat/nmo-api-vendor branch from 0cb0466 to fca9e6b Compare February 14, 2023 17:27
@malt3 malt3 requested a review from katexochen February 14, 2023 17:36
Copy link
Copy Markdown
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐥

@malt3 malt3 merged commit 77216f7 into main Feb 14, 2023
@malt3 malt3 deleted the feat/nmo-api-vendor branch February 14, 2023 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file no changelog Change won't be listed in release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants