Skip to content

Add peer recovery functionality to enterprise packages#1324

Merged
burgerdev merged 3 commits into
mainfrom
dav/recover-lib
May 15, 2025
Merged

Add peer recovery functionality to enterprise packages#1324
burgerdev merged 3 commits into
mainfrom
dav/recover-lib

Conversation

@davidweisse
Copy link
Copy Markdown
Member

@davidweisse davidweisse commented Mar 31, 2025

This adds the RecoverFromPeer method to the Authority which tries to recover its state from a given Coordinator host as specified in the RFC. For this, the authority first needs an issuer to build a TLS client for the connection.

@davidweisse davidweisse added the no changelog PRs not listed in the release notes label Mar 31, 2025
@davidweisse davidweisse marked this pull request as ready for review April 1, 2025 08:29
@davidweisse davidweisse requested a review from burgerdev as a code owner April 1, 2025 08:29
Comment thread coordinator/internal/authority/recovery.go Outdated
Comment thread coordinator/internal/authority/recovery.go Outdated
Comment thread coordinator/internal/authority/recovery.go Outdated
Comment thread coordinator/internal/authority/recovery.go Outdated
Comment thread coordinator/internal/authority/recovery.go Outdated
Comment thread coordinator/internal/authority/recovery.go Outdated
@burgerdev
Copy link
Copy Markdown
Member

I'm currently piecing together a working HA branch from the various enabling commits, and taking over this branch for now to address feedback on #1317 and for putting this functionality into the enterprise tree.

@davidweisse davidweisse force-pushed the dav/recover-handler branch 2 times, most recently from 4905836 to 47a184e Compare April 7, 2025 09:39
@katexochen katexochen added the needs: rework PR author needs to work in feedback label Apr 8, 2025
@katexochen katexochen added this to the v1.8.0 milestone Apr 8, 2025
@davidweisse davidweisse force-pushed the dav/recover-handler branch from 47a184e to 647b57e Compare April 8, 2025 08:29
Base automatically changed from dav/recover-handler to main April 8, 2025 09:55
@burgerdev burgerdev changed the base branch from main to burgerdev/peerdiscovery-struct April 9, 2025 15:06
@burgerdev burgerdev added needs: review Someone needs to review to bring this forward and removed needs: rework PR author needs to work in feedback labels Apr 9, 2025
@burgerdev burgerdev force-pushed the burgerdev/peerdiscovery-struct branch from 3eec88c to 5e09aba Compare April 15, 2025 09:17
@burgerdev burgerdev added needs: rework PR author needs to work in feedback and removed needs: review Someone needs to review to bring this forward labels Apr 15, 2025
Base automatically changed from burgerdev/peerdiscovery-struct to main April 15, 2025 10:23
@burgerdev burgerdev force-pushed the dav/recover-lib branch 4 times, most recently from cdd96ef to d3d17cd Compare May 8, 2025 08:03
@burgerdev burgerdev added needs: review Someone needs to review to bring this forward and removed needs: rework PR author needs to work in feedback labels May 8, 2025
@burgerdev burgerdev requested a review from katexochen May 8, 2025 08:55
@burgerdev burgerdev changed the title Add peer recovery function to authority Add peer recovery functionality to enterprise packages May 8, 2025
Comment thread enterprise/coordinator/recovery/recovery.go Outdated
Comment thread enterprise/coordinator/recovery/recovery.go Outdated
Comment thread enterprise/coordinator/recovery/recovery.go Outdated
Comment thread enterprise/coordinator/recovery/recovery_test.go Outdated
Comment thread enterprise/coordinator/recovery/recovery.go Outdated
Comment thread enterprise/coordinator/recovery/recovery.go Outdated
Comment thread enterprise/coordinator/recovery/recovery.go Outdated
Comment thread enterprise/coordinator/recovery/recovery_test.go Outdated
Comment thread enterprise/coordinator/recovery/recovery_test.go Outdated
Comment thread enterprise/coordinator/recovery/recovery_test.go Outdated
@burgerdev burgerdev force-pushed the dav/recover-lib branch 3 times, most recently from 04f17e4 to 128d9b7 Compare May 13, 2025 10:17
Comment thread coordinator/internal/userapi/userapi.go
@burgerdev burgerdev force-pushed the dav/recover-lib branch 2 times, most recently from a76997d to 1d3164e Compare May 14, 2025 06:34
@katexochen katexochen modified the milestones: v1.8.0, v1.9.0 May 14, 2025
Copy link
Copy Markdown
Contributor

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Comment thread enterprise/coordinator/recovery/recovery.go Outdated
@burgerdev burgerdev merged commit e1f961c into main May 15, 2025
14 of 16 checks passed
@burgerdev burgerdev deleted the dav/recover-lib branch May 15, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: review Someone needs to review to bring this forward no changelog PRs not listed in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants