Feat (data): support checklist data format#103
Merged
e11sy merged 3 commits intorelease/2.0from Nov 5, 2024
Merged
Conversation
neSpecc
requested changes
Nov 5, 2024
| * @returns true if data related to the List tool, false otherwise | ||
| */ | ||
| function instanceOfListData(data: ListData | OldListData): data is OldListData { | ||
| function instanceOfListData(data: ListData | OldListData | OldChecklistData): data is OldListData { |
Contributor
There was a problem hiding this comment.
function name means checking passed value to be ListData (new). But it checks for the OldListData.
| * Method that checks if data is related to the List or NestedListTool | ||
| * @param data - data of the List or NestedListTool | ||
| * @returns true if data related to the List tool, false if to Nested List tool | ||
| * Method that checks if data is related to the List Tool |
|
|
||
| /** | ||
| * Method that checks if data is related to the Checklist tool | ||
| * @param data - data of the Checklist of NestedList tool |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param data - data of the Checklist of NestedList tool | |
| * @param data - data of the Checklist or NestedList tool |
neSpecc
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Checklist data format is not supported for this tool
Solution
Improved
normalizeData()method that now checks if data is related to the Checklist tool and converts it to Nested List data