Conversation
gohabereg
approved these changes
Oct 16, 2023
ilyamore88
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes:
requestAnimationFramecall on renderThe problem
There is a bug in Safari. When we call
blocks.render()it leads theonChangecall.Explanation
The
blocks.render()contains a mutation observer mutex:But the
Paragraph's render creates a DOM and inserts a text usingrequestAnimationFrame— so text inserted in some time after render. It leads theonChangecall since Block's DOM is changed.Bug happened only in Safari, because
Renderer.render()promise resolves in therequestIdleCallback(which happened afterrequestAnimationFrame), but Safari does not support it, and it uses polypill (working on setTimeout) instead, so promise resolves before Paragraph Dom mutation.Solution
The first and simplest solution was to wrap
this.Editor.ModificationsObserver.enable();intorequestAnimationFrameas well.But more right way is to remove
requestAnimationFramefrom Paragraph render since it has no sense — it leads 2 layouts instead of one. For performance reason, it's important to not to calldrawViewin a constructor, butrendercan put a text withoutRaF