Feat (UI): make header and add-column button sticky on scroll#181
Merged
e11sy merged 2 commits intoeditor-js:masterfrom May 13, 2025
Merged
Feat (UI): make header and add-column button sticky on scroll#181e11sy merged 2 commits intoeditor-js:masterfrom
e11sy merged 2 commits intoeditor-js:masterfrom
Conversation
e11sy
approved these changes
May 13, 2025
neSpecc
reviewed
May 13, 2025
Contributor
neSpecc
left a comment
neSpecc
left a comment
There was a problem hiding this comment.
Increment a patch version please
neSpecc
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/editor-js/table/issues/163
Fix
Changed .tc-add-column element to match grid system of table.
Added position sticky and top 0 css rules.
Set Z-index of header row to 2 and added background color
resolves #163